Re: [PATCH v2] swig: fix build with musl

[Luca Boccassi <luca.boccassi@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1879 bytes --]

On Sat, 2019-03-02 at 23:03 +0000, Richard Purdie wrote:
> On Sat, 2019-03-02 at 18:12 +0000, Richard Purdie wrote:
> > On Fri, 2019-03-01 at 16:36 +0000, luca.boccassi@gmail.com wrote:
> > > From: Luca Boccassi <luca.boccassi@microsoft.com>
> > > 
> > > Building with musl currently fails. The fix has been committed
> > > upstream, so backport it.
> > > Note that it requires the recent change to use autoconf's
> > > do_configure
> > > as it modifies a bison file which is used at make-dist time, so
> > > it
> > > triggers an autoconf rerun which was not working previously due
> > > to
> > > the
> > > custom do_configure step that was removed recently by:
> > > a9b1f9eca963 ("swig: Fix configure failure")
> > > 
> > > Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> > > ---
> > > v2: fixed upstream metadata format in patch header
> > 
> > Fails in testing:
> > 
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/15/builds/585
> > 
> > May need a bison-native DEPENDS?

It does require bison, and I feel very silly as I have added it to the
internal build and forgot to include it in the patch! Sorry :-)

> I tried that, it fails with other problems :(
> 
> For example:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/353
> 
> Cheers,
> 
> Richard

I thought that would have been fixed by:

95c78d2166d3 ("swig: Fix configure failure")

Upstream's configure step creates that directory that is missing and
causes the build failure showed by the logs. I thought avoiding a
custom do_configure would fix that, but evidently it doesn't!

I've sent a v3 with the bison dependency and with a workaround I've
successfully used in our internal build, which creates the directory
manually in a do_configure_append block.

Thanks for the review!

-- 
Kind regards,
Luca Boccassi

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 499 bytes --]