From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Andrej Valek <andrej.valek@siemens.com>,
openembedded-core@lists.openembedded.org
Cc: Pascal Bach <pascal.bach@siemens.com>,
Adrian Freihofer <adrian.freihofer@siemens.com>
Subject: Re: [OE-core][PATCH v2 1/2] bitbake.conf: Split optimization into common part
Date: Wed, 25 Nov 2020 10:30:46 +0000 [thread overview]
Message-ID: <32812d8ef3f7b29686e3a591e29315e82a80ead5.camel@linuxfoundation.org> (raw)
In-Reply-To: <20201123190029.13811-1-andrej.valek@siemens.com>
On Mon, 2020-11-23 at 20:00 +0100, Andrej Valek wrote:
> This option allows correctly handle the release/debug flags separation in
> upper recipe like cmake. Adopt SELECTED_OPTIMIZATION usage in other
> recipes.
>
> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
> Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> ---
> meta/conf/bitbake.conf | 7 ++++---
> meta/conf/distro/include/security_flags.inc | 8 ++++----
> meta/conf/local.conf.sample.extended | 1 +
> meta/recipes-devtools/valgrind/valgrind_3.16.1.bb | 1 +
> 4 files changed, 10 insertions(+), 7 deletions(-)
I am a bit worried about this as we're effectively letting cmake's idea
of flags separation determine how we have to set things in OE. Once we
go down this route, we're going to have problems any time we try and
add a new compiler flag.
What does this buy us in the end?
Cheers,
Richard
next prev parent reply other threads:[~2020-11-25 10:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-22 12:48 [OE-core][PATCH 1/2] bitbake.conf: Split optimization into common part Andrej Valek
2020-11-22 12:48 ` [OE-core][PATCH 2/2] cmake: split release and debug flags Andrej Valek
2020-11-23 15:03 ` Khem Raj
2020-11-23 19:00 ` [OE-core][PATCH v2 1/2] bitbake.conf: Split optimization into common part Andrej Valek
2020-11-23 19:17 ` Richard Purdie
2020-11-24 8:01 ` Andrej Valek
2020-11-24 13:34 ` Richard Purdie
2020-11-24 18:47 ` Andrej Valek
2020-11-24 19:29 ` Khem Raj
2020-11-25 10:30 ` Richard Purdie [this message]
2020-11-25 16:58 ` Andrej Valek
2020-11-23 19:00 ` [OE-core][PATCH v2 2/2] cmake: split release and debug flags Andrej Valek
2020-11-24 19:32 ` Khem Raj
2020-11-25 10:23 ` Andrej Valek
2020-11-25 15:45 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32812d8ef3f7b29686e3a591e29315e82a80ead5.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=adrian.freihofer@siemens.com \
--cc=andrej.valek@siemens.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pascal.bach@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox