Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: hongxu <hongxu.jia@windriver.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 3/3] deb: do not insert feed uris if apt not installed
Date: Fri, 15 Jan 2021 22:21:21 +0000	[thread overview]
Message-ID: <32c70df536b241c06742c5e75a4aaab8f02f9d88.camel@linuxfoundation.org> (raw)
In-Reply-To: <20210115094536.18651-3-hongxu.jia@windriver.com>

On Fri, 2021-01-15 at 17:45 +0800, hongxu wrote:
> - The dir /etc/apt was created in package apt, if package apt was not
>   installed, there is no need to insert package feed. Otherwise, it
>   will fail with no such dir
> 
> - Output the result of apt install
> 
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta/lib/oe/package_manager/deb/__init__.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oe/package_manager/deb/__init__.py b/meta/lib/oe/package_manager/deb/__init__.py
> index 10ad707c23..1e2278d6a4 100644
> --- a/meta/lib/oe/package_manager/deb/__init__.py
> +++ b/meta/lib/oe/package_manager/deb/__init__.py
> @@ -287,7 +287,8 @@ class DpkgPM(OpkgDpkgPM):
>  
> 
> 
> 
>          try:
>              bb.note("Installing the following packages: %s" % ' '.join(pkgs))
> -            subprocess.check_output(cmd.split(), stderr=subprocess.STDOUT)
> +            output = subprocess.check_output(cmd.split(), stderr=subprocess.STDOUT)
> +            bb.note(output.decode("utf-8"))
>          except subprocess.CalledProcessError as e:
>              (bb.fatal, bb.warn)[attempt_only]("Unable to install packages. "
>                                                "Command '%s' returned %d:\n%s" %
> @@ -343,8 +344,12 @@ class DpkgPM(OpkgDpkgPM):
>          if feed_uris == "":
>              return
>  
> 
> 
> 
> +
>          sources_conf = os.path.join("%s/etc/apt/sources.list"
>                                      % self.target_rootfs)
> +        if not os.path.exists(os.path.dirname(sources_conf)):
> +            return
> +
>          arch_list = []
>  
> 
> 
> 
>          if feed_archs is None:

I think this is resulting in these warnings:

https://autobuilder.yoctoproject.org/typhoon/#/builders/50/builds/2925

Cheers,

Richard


  reply	other threads:[~2021-01-15 22:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15  9:45 [PATCH 1/3] dpkg: add nativesdk support hongxu
2021-01-15  9:45 ` [PATCH 2/3] apt: " hongxu
2021-01-15 11:26   ` [OE-core] " Richard Purdie
     [not found]   ` <165A643B5E417599.21794@lists.openembedded.org>
2021-01-15 16:51     ` Richard Purdie
2021-01-16  2:49       ` hongxu
2021-01-15  9:45 ` [PATCH 3/3] deb: do not insert feed uris if apt not installed hongxu
2021-01-15 22:21   ` Richard Purdie [this message]
2021-01-16  2:46     ` [OE-core] " hongxu
2021-01-16  3:49     ` [PATCH V2] " hongxu
2021-01-15 22:15 ` [OE-core] [PATCH 1/3] dpkg: add nativesdk support Richard Purdie
2021-01-16  2:50   ` hongxu
2021-01-16  3:47   ` [PATCH V2] " hongxu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32c70df536b241c06742c5e75a4aaab8f02f9d88.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox