Got it. I've sent out V2. Regards, Qi On 08/06/2021 05:25 PM, Martin Jansa wrote: > Can you please bump the script version as well? > > On Fri, Aug 6, 2021 at 11:03 AM Chen Qi > wrote: > > Currently lines like below are converted. > e.g. > # IMAGE_INSTALL_append = " A" > > But lines without a leading whitespace are not converted. > e.g. > #IMAGE_INSTALL_append = " A" > > We should be converting both. > > Signed-off-by: Chen Qi > > --- > scripts/contrib/convert-overrides.py > > | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/contrib/convert-overrides.py > > b/scripts/contrib/convert-overrides.py > > index e4a310d1d6..4d41a4c475 100755 > --- a/scripts/contrib/convert-overrides.py > > +++ b/scripts/contrib/convert-overrides.py > > @@ -69,15 +69,15 @@ packagevars = packagevars + imagevars > > vars_re = {} > for exp in vars: > - vars_re[exp] = > (re.compile('((^|[\'"\s\-\+])[A-Za-z0-9_\-:${}\.]+)_' + exp), > r"\1:" + exp) > + vars_re[exp] = > (re.compile('((^|[#\'"\s\-\+])[A-Za-z0-9_\-:${}\.]+)_' + exp), > r"\1:" + exp) > > shortvars_re = {} > for exp in shortvars: > - shortvars_re[exp] = > (re.compile('((^|[\'"\s\-\+])[A-Za-z0-9_\-:${}\.]+)_' + exp + > '([\(\'"\s:])'), r"\1:" + exp + r"\3") > + shortvars_re[exp] = > (re.compile('((^|[#\'"\s\-\+])[A-Za-z0-9_\-:${}\.]+)_' + exp + > '([\(\'"\s:])'), r"\1:" + exp + r"\3") > > package_re = {} > for exp in packagevars: > - package_re[exp] = (re.compile('(^|[\'"\s\-\+]+)' + exp + '_' > + '([$a-z"\'\s%\[<{\\\*].)'), r"\1" + exp + r":\2") > + package_re[exp] = (re.compile('(^|[#\'"\s\-\+]+)' + exp + '_' > + '([$a-z"\'\s%\[<{\\\*].)'), r"\1" + exp + r":\2") > > # Other substitutions to make > subs = { > -- > 2.30.2 > > > >