From: Steve Sakoman <steve@sakoman.com>
To: openembedded-core@lists.openembedded.org
Subject: [OE-core][scarthgap 12/16] udev-extraconf: Add collect flag to mount
Date: Fri, 20 Sep 2024 06:39:10 -0700 [thread overview]
Message-ID: <33de458b758c2fe430b515ff419dd200ea97ca0b.1726839438.git.steve@sakoman.com> (raw)
In-Reply-To: <cover.1726839438.git.steve@sakoman.com>
From: Colin McAllister <colinmca242@gmail.com>
Adds extra "--collect" flag to the mount command within
automount_systemd. This is intended to fix an observed deadlock after
rapidly inserting and removing external media. This is because if the
mount command fails, the transient mount will enter a failed state. The
next time the media is inserted, automount_systemd bails because the
first consition finds that the file path for the failed transient mount
still exists. This leaves the external media unmounted and cannot be
mounted until the mount is fixed via systemctl or the device is
rebooted.
Adding "--collect" ensures that the transient mount is cleaned up after
entering a failed state, which ensures that the media can still be
mounted when it's re-inserted.
(From OE-Core rev: f0cda74d73eb8c14cd6f695f514108f1e94984a6)
Signed-off-by: Colin McAllister <colinmca242@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/meta/recipes-core/udev/udev-extraconf/mount.sh b/meta/recipes-core/udev/udev-extraconf/mount.sh
index c19e2aa68a..eb84a468be 100644
--- a/meta/recipes-core/udev/udev-extraconf/mount.sh
+++ b/meta/recipes-core/udev/udev-extraconf/mount.sh
@@ -98,7 +98,7 @@ automount_systemd() {
;;
esac
- if ! $MOUNT --no-block -t auto $DEVNAME "$MOUNT_BASE/$name"
+ if ! $MOUNT --collect --no-block -t auto $DEVNAME "$MOUNT_BASE/$name"
then
#logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"$MOUNT_BASE/$name\" failed!"
rm_dir "$MOUNT_BASE/$name"
--
2.34.1
next prev parent reply other threads:[~2024-09-20 13:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 13:38 [OE-core][scarthgap 00/16] Patch review Steve Sakoman
2024-09-20 13:38 ` [OE-core][scarthgap 01/16] Revert "wpa-supplicant: Upgrade 2.10 -> 2.11" Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 02/16] libpcap: Security fix for CVE-2023-7256 & CVE-2024-8006 Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 03/16] openssl: Upgrade 3.2.2 -> 3.2.3 Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 04/16] python3: upgrade 3.12.4 -> 3.12.5 Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 05/16] python3: skip readline limited history tests Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 06/16] python3: Upgrade 3.12.5 -> 3.12.6 Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 07/16] buildhistory: Fix intermittent package file list creation Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 08/16] buildhistory: Restoring files from preserve list Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 09/16] buildhistory: Simplify intercept call sites and drop SSTATEPOSTINSTFUNC usage Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 10/16] qemu: back port patches to fix riscv64 build failure Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 11/16] gcc: Fix spurious '/' in GLIBC_DYNAMIC_LINKER on microblaze Steve Sakoman
2024-09-20 13:39 ` Steve Sakoman [this message]
2024-09-20 13:39 ` [OE-core][scarthgap 13/16] busybox: Fix cut with "-s" flag Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 14/16] bluez5: remove redundant patch for MAX_INPUT Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 15/16] create-sdpx-2.2.bbclass: Switch from exists to isfile checking debugsrc Steve Sakoman
2024-09-20 13:39 ` [OE-core][scarthgap 16/16] bind: Fix build with the `httpstats` package config enabled Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33de458b758c2fe430b515ff419dd200ea97ca0b.1726839438.git.steve@sakoman.com \
--to=steve@sakoman.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox