From: Ross Burton <Ross.Burton@arm.com>
To: "Qi.Chen@windriver.com" <Qi.Chen@windriver.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core][PATCH V3 2/5] cpio: fix ptest-runner dependency
Date: Thu, 17 Apr 2025 11:42:57 +0000 [thread overview]
Message-ID: <342154B5-DC17-4145-B2FC-985D7685B1E6@arm.com> (raw)
In-Reply-To: <20250414053503.1180029-2-Qi.Chen@windriver.com>
On 14 Apr 2025, at 06:35, Chen Qi via lists.openembedded.org <Qi.Chen=windriver.com@lists.openembedded.org> wrote:
> Also, the above DEPENDS:append:class-targets lacks a leading whitespace,
> add it.
Not strictly true:
> -DEPENDS:append:class-target = "${@bb.utils.contains('PTEST_ENABLED', '1', ' ptest-runner', '', d)}"
> +DEPENDS:append:class-target = " ${@bb.utils.contains('PTEST_ENABLED', '1', ' ptest-runner', '', d)}"
There’s whitespace in the value being added, so if PTEST_ENABLED is false you don’t get whitespace appended for no reason.
Ross
next prev parent reply other threads:[~2025-04-17 11:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 5:34 [OE-core][PATCH V3 1/5] classes/recipes: remove unnecessary qemu inherit and use qemuwrapper-cross Qi.Chen
2025-04-14 5:35 ` [OE-core][PATCH V3 2/5] cpio: fix ptest-runner dependency Qi.Chen
2025-04-17 11:42 ` Ross Burton [this message]
2025-04-14 5:35 ` [OE-core][PATCH V3 3/5] nativesdk.bbclass: handle PACKAGE_WRITE_DEPS Qi.Chen
2025-04-14 5:35 ` [OE-core][PATCH V3 4/5] image/populate_sdk.bbclass: drop qemuwrapper-cross from DEPENDS Qi.Chen
2025-04-14 5:35 ` [OE-core][PATCH V3 5/5] lib/classes/recipes: refactor qemu.bbclass functions into library functions Qi.Chen
2025-04-16 16:55 ` [OE-core][PATCH V3 1/5] classes/recipes: remove unnecessary qemu inherit and use qemuwrapper-cross Richard Purdie
2025-04-17 2:26 ` Chen, Qi
2025-04-17 10:11 ` Richard Purdie
2025-04-20 4:09 ` Chen, Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=342154B5-DC17-4145-B2FC-985D7685B1E6@arm.com \
--to=ross.burton@arm.com \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox