Re: [PATCH 1/1] buildhistory.bbclass: always record PKG, PKGE, PKGV and PKGR

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Thursday 26 September 2013 13:23:32 Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
> 
> The buildhistory.bbclass always records PV instead of PKGV. However,
> the buildhistory-diff script treats PKGV as a monitored variable
> instead of PV.
> 
> If a recipe's PV changes, for example, hello_1.0.bb is renamed to
> hello_2.0.bb, then buildhistory-diff reports nothing because PV is
> not monitored and PKGV is not recorded.
> 
> So the buildhistory.bbclass should always record PKGV no matter it
> equals to PV or not.
> 
> The same logic applies to PKG, PKGE and PKGR.
> 
> [YOCTO #5263]
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  meta/classes/buildhistory.bbclass |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/meta/classes/buildhistory.bbclass
> b/meta/classes/buildhistory.bbclass index 3da03c8..cea917c 100644
> --- a/meta/classes/buildhistory.bbclass
> +++ b/meta/classes/buildhistory.bbclass
> @@ -277,10 +277,10 @@ def write_pkghistory(pkginfo, d):
>          f.write("PR = %s\n" %  pkginfo.pr)
> 
>          pkgvars = {}
> -        pkgvars['PKG'] = pkginfo.pkg if pkginfo.pkg != pkginfo.name else ''
> -        pkgvars['PKGE'] = pkginfo.pkge if pkginfo.pkge != pkginfo.pe else
> '' -        pkgvars['PKGV'] = pkginfo.pkgv if pkginfo.pkgv != pkginfo.pv
> else '' -        pkgvars['PKGR'] = pkginfo.pkgr if pkginfo.pkgr !=
> pkginfo.pr else '' +        pkgvars['PKG'] = pkginfo.pkg
> +        pkgvars['PKGE'] = pkginfo.pkge
> +        pkgvars['PKGV'] = pkginfo.pkgv
> +        pkgvars['PKGR'] = pkginfo.pkgr
>          for pkgvar in pkgvars:
>              val = pkgvars[pkgvar]
>              if val:

Please see my comment on the bug (just added):
https://bugzilla.yoctoproject.org/show_bug.cgi?id=5263

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre