Re: [PATCH] buildhistory: record removals with Git 2.0 and later

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Friday 31 May 2013 20:29:19 Jonathan Liu wrote:
> On 31/05/2013 7:42 PM, Jonathan Liu wrote:
> > There is a behavior change with Git 2.0 where "git add ." will no
> > longer record removals by default unless -A (--all) is specified.
> > Change to "git add -A ." so removals are recorded with Git 2.0 and
> > later.
> > 
> > Signed-off-by: Jonathan Liu <net147@gmail.com>
> > ---
> > 
> >   meta/classes/buildhistory.bbclass | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Hmm... looks like I interpreted the Git warning incorrectly. Maybe I
> need to look into this a bit more and perhaps change the commit message.
> 
> The following appears after a build with buildhistory enabled:
> warning: You ran 'git add' with neither '-A (--all)' or '--ignore-removal',
> whose behaviour will change in Git 2.0 with respect to paths you removed.
> Paths like 'test.txt' that are
> removed from your working tree are ignored with this version of Git.
> 
> * 'git add --ignore-removal <pathspec>', which is the current default,
>    ignores paths you removed from your working tree.
> 
> * 'git add --all <pathspec>' will let you also record the removals.
> 
> Run 'git status' to check the paths you removed from your working tree.

So it seems the change is reasonable but yes perhaps the commit message should 
change to mention that it also avoids a warning with 1.8.3.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre