Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	Jose Quaresma <quaresma.jose@gmail.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: RE: [OE-core] [PATCH] externalsrc.bbclass: Allow externalsrc to be extended with extra classes
Date: Wed, 20 Oct 2021 10:57:00 +0000	[thread overview]
Message-ID: <35229a81fcb740edb3d77e35c8ebc787@axis.com> (raw)
In-Reply-To: <86a6794721045c94bc4cd445a051ff1df40baa6e.camel@linuxfoundation.org>

> -----Original Message-----
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> Sent: den 20 oktober 2021 11:59
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; Jose Quaresma
> <quaresma.jose@gmail.com>
> Cc: OE-core <openembedded-core@lists.openembedded.org>
> Subject: Re: [OE-core] [PATCH] externalsrc.bbclass: Allow externalsrc to
> be extended with extra classes
> 
> On Wed, 2021-10-20 at 09:09 +0000, Peter Kjellerstedt wrote:
> > I thought of another problem with the wrapper class solution: if we 
> > needto actually backport a newer version of the class from, e.g., 
> > Poky master, then there is now no natural place for it since it is 
> > occupied by the wrapper class. That means we would either have to 
> > rename the backported class, or put it somewhere else than in 
> > "classes". It also means backporting a class requires the wrapper 
> > class to be modified.
> >
> > Here is a question for Richard: what do you think of an idea I had to
> > add support in bitbake for extending classes? I do not mean to add 
> > something like bbclassappend, as I know that is troublesome. My idea 
> > instead is something like the prefuncs/postfuncs that we have for 
> > functions. I.e., before actually doing the inherit of a classfoo, 
> > bitbake would inherit anything specified in BBCLASS_PRE_INHERIT:foo, 
> > and after inheriting the class it would automatically inherit 
> > anything in BBCLASS_POST_INHERIT:foo.  That way one can simply extend 
> > a class through normal variable operations, making it easy to do, 
> > e.g., in the distro configuration.
> 
> That sounds very like a bbclassappend under a different name?
> 
> Cheers,
> 
> Richard

Well, I guess it is similar to what a bbclassappend file suffix would 
entail, but more flexible and controlled. Do you think something like 
this would work, or have I missed some technical problems that would 
prevent it? And if you think it is technically possible, would you be 
willing to accept a patch that implements it?

//Peter


  reply	other threads:[~2021-10-20 10:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 17:03 [PATCH] externalsrc.bbclass: Allow externalsrc to be extended with extra classes Peter Kjellerstedt
2021-10-19 17:15 ` [OE-core] " Jose Quaresma
2021-10-20  1:31   ` Peter Kjellerstedt
     [not found]   ` <16AF9916496D59D2.6466@lists.openembedded.org>
2021-10-20  9:09     ` Peter Kjellerstedt
2021-10-20  9:58       ` Richard Purdie
2021-10-20 10:57         ` Peter Kjellerstedt [this message]
2021-10-20 11:21           ` Richard Purdie
2021-10-20 12:42             ` Peter Kjellerstedt
2021-10-20 12:58               ` Alexander Kanavin
2021-10-20 20:39       ` Douglas Royds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35229a81fcb740edb3d77e35c8ebc787@axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=quaresma.jose@gmail.com \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox