From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mail.openembedded.org (Postfix) with ESMTP id 3B816605C3 for ; Thu, 17 Nov 2016 15:23:20 +0000 (UTC) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 17 Nov 2016 07:23:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,506,1473145200"; d="scan'208,217";a="192578604" Received: from jgperezc.zpn.intel.com (HELO [10.219.5.31]) ([10.219.5.31]) by fmsmga004.fm.intel.com with ESMTP; 17 Nov 2016 07:23:21 -0800 To: "Burton, Ross" , Francisco Pedraza References: <1479257423-4281-1-git-send-email-francisco.j.pedraza.gonzalez@intel.com> From: Jose Perez Carranza Message-ID: <358803d5-7678-9c6e-2017-9007263d02d5@linux.intel.com> Date: Thu, 17 Nov 2016 09:33:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Cc: OE-core Subject: Re: [PATCH] Test needed to verify postinst script order. X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 15:23:21 -0000 Content-Type: multipart/alternative; boundary="------------DA3F07FCAF74AF27D72E5FD2" --------------DA3F07FCAF74AF27D72E5FD2 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 11/17/2016 06:14 AM, Burton, Ross wrote: > > On 16 November 2016 at 00:50, Francisco Pedraza > > wrote: > > Will verify the following: > 1. Compile a minimal image. > 2. The compiled image will add the created layer with the > recipes postinstz postinsta postinstb postinstd postinstp postinstt > created previously at "meta-selftest/recipes-test" > 2. Run qemu > 3. Validate the task execution order. > V4 > > > This is missing the test that some postinsts should be happening at > rootfs time. I have assigned the bug 8433 and I will send a different patch to add those test cases, I'm just waiting to the final implementation of this patch to be accepted to avoid execution and merge conflicts. > > Also, can it permute PACKAGE_CLASSES (rotate through all three > options) so it exercises all backends. > > Signed-off-by: Francisco Pedraza > > > --- > .../recipes-test/postinsta/postinsta_1.0.bb > | 20 +++++++++++ > .../recipes-test/postinstb/postinstb_1.0.bb > | 22 ++++++++++++ > .../recipes-test/postinstd/postinstd_1.0.bb > | 22 ++++++++++++ > .../recipes-test/postinstp/postinstp_1.0.bb > | 22 ++++++++++++ > .../recipes-test/postinstt/postinstt_1.0.bb > | 22 ++++++++++++ > .../recipes-test/postinstz/postinstz_1.0.bb > | 12 +++++++ > > > For clarity can all of these be squashed into a single recipe with > clearer names? > > Ross > > --------------DA3F07FCAF74AF27D72E5FD2 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 8bit



On 11/17/2016 06:14 AM, Burton, Ross wrote:

On 16 November 2016 at 00:50, Francisco Pedraza <francisco.j.pedraza.gonzalez@intel.com> wrote:
Will verify the following:
1. Compile a minimal image.
2. The compiled image will add the created layer with the
recipes postinstz postinsta postinstb postinstd postinstp postinstt
created previously at "meta-selftest/recipes-test"
2. Run qemu
3. Validate the task execution order.
V4

This is missing the test that some postinsts should be happening at rootfs time.
I have assigned the bug 8433 and I will send a different patch to add those test cases, I'm just waiting to the final implementation of this  patch to be accepted to avoid execution and merge conflicts. 

Also, can it permute PACKAGE_CLASSES (rotate through all three options) so it exercises all backends.

Signed-off-by: Francisco Pedraza <francisco.j.pedraza.gonzalez@intel.com>
---
 .../recipes-test/postinsta/postinsta_1.0.bb        | 20 +++++++++++
 .../recipes-test/postinstb/postinstb_1.0.bb        | 22 ++++++++++++
 .../recipes-test/postinstd/postinstd_1.0.bb        | 22 ++++++++++++
 .../recipes-test/postinstp/postinstp_1.0.bb        | 22 ++++++++++++
 .../recipes-test/postinstt/postinstt_1.0.bb        | 22 ++++++++++++
 .../recipes-test/postinstz/postinstz_1.0.bb        | 12 +++++++

For clarity can all of these be squashed into a single recipe with clearer names?

Ross



--------------DA3F07FCAF74AF27D72E5FD2--