public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Qi.Chen@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 1/2] classes/recipes: remove unnecessary qemu inherit and qemu-native dependency
Date: Thu, 10 Apr 2025 07:15:20 +0100	[thread overview]
Message-ID: <35ee8bfe577addc9e6ae978588b5a071be82b478.camel@linuxfoundation.org> (raw)
In-Reply-To: <20250410040825.1283228-1-Qi.Chen@windriver.com>

On Wed, 2025-04-09 at 21:08 -0700, Chen Qi via lists.openembedded.org wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
> 
> Some classes/recipes inherit qemu.bbclass but does not actually use anything
> from it. Besides, putting qemu-native in PACKAGE_WRITE_DEPS is not needed because
> the process of generating package does not need qemu-native.
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  meta/classes-recipe/fontcache.bbclass           | 3 ---
>  meta/classes-recipe/gio-module-cache.bbclass    | 3 ---
>  meta/classes-recipe/gtk-immodules-cache.bbclass | 4 ----
>  meta/classes-recipe/manpages.bbclass            | 2 --
>  meta/classes-recipe/pixbufcache.bbclass         | 5 +----
>  meta/recipes-core/systemd/systemd_257.4.bb      | 3 +--
>  meta/recipes-core/udev/eudev_3.2.14.bb          | 2 +-
>  7 files changed, 3 insertions(+), 19 deletions(-)
> 
> diff --git a/meta/classes-recipe/fontcache.bbclass b/meta/classes-recipe/fontcache.bbclass
> index 6f4978369d..6082af08f3 100644
> --- a/meta/classes-recipe/fontcache.bbclass
> +++ b/meta/classes-recipe/fontcache.bbclass
> @@ -9,9 +9,6 @@
>  # packages.
>  #
>  
> -PACKAGE_WRITE_DEPS += "qemu-native"
> -inherit qemu
> -
>  FONT_PACKAGES ??= "${PN}"
>  FONT_PACKAGES:class-native = ""
>  FONT_EXTRA_RDEPENDS ?= "${MLPREFIX}fontconfig-utils"

I picked one of these to validate this as I didn't quite believe we didn't use qemu there.
fontconfig.bbclass has:

fontcache_common() {
if [ -n "$D" ] ; then
	$INTERCEPT_DIR/postinst_intercept update_font_cache ${PKG} mlprefix=${MLPREFIX} binprefix=${MLPREFIX} \

in it's postinstall script. Then in scripts/postinst-
intercepts/update_font_cache we have:

PSEUDO_UNLOAD=1 ${binprefix}qemuwrapper -L $D -E ${fontconfigcacheenv} $D${libexecdir}/${binprefix}fc-cache --sysroot=$D --system-only ${fontconfigcacheparams}

so I'm afraid it does use qemu and you can't simply drop the class
inherit or dependency as it is used.

Cheers,

Richard



  parent reply	other threads:[~2025-04-10  6:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10  4:08 [OE-core][PATCH 1/2] classes/recipes: remove unnecessary qemu inherit and qemu-native dependency Qi.Chen
2025-04-10  4:08 ` [OE-core][PATCH 2/2] lib/classes/recipes: refactor qemu.bbclass functions into library functions Qi.Chen
2025-04-10  7:50   ` Alexander Kanavin
2025-04-10  8:54     ` Chen, Qi
2025-04-10  6:15 ` Richard Purdie [this message]
2025-04-10  6:31   ` [OE-core][PATCH 1/2] classes/recipes: remove unnecessary qemu inherit and qemu-native dependency Chen, Qi
2025-04-10  6:42     ` Richard Purdie
2025-04-10  6:45       ` Chen, Qi
2025-04-10  7:27         ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35ee8bfe577addc9e6ae978588b5a071be82b478.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Qi.Chen@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox