From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by mx.groups.io with SMTP id smtpd.web12.38805.1605549905604413082 for ; Mon, 16 Nov 2020 10:05:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=dL/l0yUG; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.215.195, mailfrom: scott.branden@broadcom.com) Received: by mail-pg1-f195.google.com with SMTP id 62so13888517pgg.12 for ; Mon, 16 Nov 2020 10:05:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to; bh=4Wd44XxQLIV8qbYEMjH7a6FKc9CLlyTSW7eGuwAtnFU=; b=dL/l0yUG6u17UAiBiZR6TAhFF+OEeE1dAdSpfabFhZBkix0XmSJ/vT8NfSvVCM1X0z duCI66pB2JuBsqSPnQmfTe0XjpplMEaYvQexF2QFrs0Fnk0J513Nlfjh3g1y6ZNYF0Yk HIPBUsbIZDfY4egaixNKtSqBj4Ckdhg349d0k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=4Wd44XxQLIV8qbYEMjH7a6FKc9CLlyTSW7eGuwAtnFU=; b=uly/cHNUjVThXG7pgxV1UNsNJdOsYwr6AeAg0sHDK76LHErm5Eym0CAYc6OIi1QIOJ yj7yDo9HLp917tKT4zJ/pDu/SuVlymxFke4ElaBtQkIp5hvo6kmsEoEOff57SZb2BHNE l0H3bq+yf5ZLPnVwEEjMOwsD6Le9kKa5adqtuimSdLv+XTJrXjPKCQF54UbfvAqQfEqL JnCNhbg5yv6yKGWCO0wfGZzwDZDx2lOpo2Nw7Fo+QVFZS69hJ7BLI1dbdv62Gw+F6mf1 rOGd6dln6W5ePq21og3fK3msCvtZUN7FgL9mpzUegjQVI56NOTxp4FAsOCUj1hOoFnUN aHog== X-Gm-Message-State: AOAM532SnzwuUtpstuX+yH0iirsm+hf66jY1AFU6r3XCC6CLdKAOxRtI DGI4FSZg9stYFxtltB2hfWGKhE1n21mxeVEtrUCH28vfynTih4JV3BI76dE4rZZFj0AP7SQL5FC VnHGk6BCJMgqpXv4WdYkEKwQgFGE3v5gyCngARFBiqbvZbXy2tnFH7dccGlXkwnphyd2CKOLwxV ugD4Pjpe3cDkPF8ds1D3BF4gkASN4= X-Google-Smtp-Source: ABdhPJwpP8dkkgwPb6R7PUYUHTX1K59fnD9K8zmGpXQB2QBEss5e7vd7sXtIZ+Xm+9AYxbE/WyhF3w== X-Received: by 2002:a17:90a:3ec6:: with SMTP id k64mr86378pjc.113.1605549904309; Mon, 16 Nov 2020 10:05:04 -0800 (PST) Return-Path: Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id p15sm62249pjg.21.2020.11.16.10.05.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Nov 2020 10:05:03 -0800 (PST) Subject: Re: [OE-core] [PATCH] kernel: provide module.lds for out of tree builds in v5.10+ To: Bruce Ashfield Cc: Richard Purdie , Lili Li , Patches and discussions about the oe-core layer References: <20201113063206.1716-1-bruce.ashfield@gmail.com> <771b373d-927a-4ac6-8716-b51f2b6d355f@broadcom.com> <1647455857E467AB.30187@lists.openembedded.org> <16474616B7B2F983.30187@lists.openembedded.org> From: "Scott Branden" Message-ID: <369d189a-4aaf-f8b9-072c-a362a8280458@broadcom.com> Date: Mon, 16 Nov 2020 10:05:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: X-Groupsio-MsgNum: 144624 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000bfb7c605b43d3761" --000000000000bfb7c605b43d3761 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-CA On 2020-11-13 9:09 p.m., Bruce Ashfield wrote: > On Fri, Nov 13, 2020 at 11:41 PM Bruce Ashfield via > lists.openembedded.org > wrote: >> On Fri, Nov 13, 2020 at 11:27 PM Bruce Ashfield via >> lists.openembedded.org >> wrote: >>> On Fri, Nov 13, 2020 at 11:19 PM Scott Branden >>> wrote: >>>> Sorry, spoke too soon. Doesn't seem to work from a clean build now. >>>> >>> How so ? Works on repeated clean builds here. For 5.4/5.8 and 5.10 >>> >> I have a theory on this. Did you directly bitbake your external module >> ? versus building the kernel first and then the module ? Yes, I was doing a direct bitbake of the external module. >> >> I'll see what I can come up with. > Confirmed. > > I have it sorted now. Doing one more clean build and will send a v2. Glad you were able to reproduce. > > Thanks for the follow up!! Looks to be merged to master now. Will pickup the latest and if anything still not working let you know. > > Bruce > >> Bruce >> >>> Bruce >>> >>>> On 2020-11-13 9:53 a.m., Scott Branden wrote: >>>> >>>> Thanks, works for me building external kernel modules. >>>> >>>> On 2020-11-12 10:32 p.m., Bruce Ashfield wrote: >>>> >>>> From: Bruce Ashfield >>>> >>>> The upstream commit 596b0474d3d [kbuild: preprocess module linker >>>> script], adds a dependency on module.lds for external module >>>> building. >>>> >>>> Since module.lds is generated as part of 'modules_prepare', we >>>> must make it available with the other kernel artifacts in the >>>> kernel shared workdir, otherwise out of tree builds fail. >>>> >>>> This fixes errors like: >>>> >>>> | make[4]: *** No rule to make target 'scripts/module.lds', needed by >>>> 'build/tmp/work/qemuarm64-poky-linux/cryptodev-module/1.11-r0/git/cryptodev.ko'. >>>> Stop. >>>> | make[4]: *** Waiting for unfinished jobs.... >>>> >>>> We also ensure that kernel-devsrc has a copy to support on >>>> target module builds that are often prepared with 'make scripts >>>> prepare'. Those targets won't regenerate it, so the build fails. >>>> If 'make modules_prepare' is used, the file will be regenerated >>>> and overwrite our copy (as expected). >>>> >>>> Signed-off-by: Pan, Kris >>>> Signed-off-by: Lili Li >>>> Signed-off-by: Bruce Ashfield >>>> >>>> Tested-by: Scott Branden >>>> >>>> --- >>>> meta/classes/kernel.bbclass | 1 + >>>> meta/recipes-kernel/linux/kernel-devsrc.bb | 6 ++++++ >>>> 2 files changed, 7 insertions(+) >>>> >>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass >>>> index be93a258f6..ccd74e61e8 100644 >>>> --- a/meta/classes/kernel.bbclass >>>> +++ b/meta/classes/kernel.bbclass >>>> @@ -494,6 +494,7 @@ do_shared_workdir () { >>>> # Copy files required for module builds >>>> cp System.map $kerneldir/System.map-${KERNEL_VERSION} >>>> [ -e Module.symvers ] && cp Module.symvers $kerneldir/ >>>> + [ -e scripts/module.lds ] && install -Dm 0644 scripts/module.lds $kerneldir/scripts/module.lds >>>> cp .config $kerneldir/ >>>> mkdir -p $kerneldir/include/config >>>> cp include/config/kernel.release $kerneldir/include/config/kernel.release >>>> diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb b/meta/recipes-kernel/linux/kernel-devsrc.bb >>>> index 81b1e36041..5f0dedbdf7 100644 >>>> --- a/meta/recipes-kernel/linux/kernel-devsrc.bb >>>> +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb >>>> @@ -100,6 +100,12 @@ do_install() { >>>> # be dealt with. >>>> # cp -a scripts $kerneldir/build >>>> >>>> + # although module.lds can be regenerated on target via 'make modules_prepare' >>>> + # there are several places where 'makes scripts prepare' is done, and that won't >>>> + # regenerate the file. So we copy it onto the target as a migration to using >>>> + # modules_prepare >>>> + cp -a --parents scripts/module.lds $kerneldir/build/ 2>/dev/null || : >>>> + >>>> if [ -d arch/${ARCH}/scripts ]; then >>>> cp -a arch/${ARCH}/scripts $kerneldir/build/arch/${ARCH} >>>> fi >>>> >>>> >>>> >>>> >>>> >>>> >>> >>> -- >>> - Thou shalt not follow the NULL pointer, for chaos and madness await >>> thee at its end >>> - "Use the force Harry" - Gandalf, Star Trek II >>> >>> >>> >> >> -- >> - Thou shalt not follow the NULL pointer, for chaos and madness await >> thee at its end >> - "Use the force Harry" - Gandalf, Star Trek II >> >> >> > --000000000000bfb7c605b43d3761 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQRQYJKoZIhvcNAQcCoIIQNjCCEDICAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg2aMIIE6DCCA9CgAwIBAgIOSBtqCRO9gCTKXSLwFPMwDQYJKoZIhvcNAQELBQAwTDEgMB4GA1UE CxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMT Ckdsb2JhbFNpZ24wHhcNMTYwNjE1MDAwMDAwWhcNMjQwNjE1MDAwMDAwWjBdMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTEzMDEGA1UEAxMqR2xvYmFsU2lnbiBQZXJzb25h bFNpZ24gMiBDQSAtIFNIQTI1NiAtIEczMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA tpZok2X9LAHsYqMNVL+Ly6RDkaKar7GD8rVtb9nw6tzPFnvXGeOEA4X5xh9wjx9sScVpGR5wkTg1 fgJIXTlrGESmaqXIdPRd9YQ+Yx9xRIIIPu3Jp/bpbiZBKYDJSbr/2Xago7sb9nnfSyjTSnucUcIP ZVChn6hKneVGBI2DT9yyyD3PmCEJmEzA8Y96qT83JmVH2GaPSSbCw0C+Zj1s/zqtKUbwE5zh8uuZ p4vC019QbaIOb8cGlzgvTqGORwK0gwDYpOO6QQdg5d03WvIHwTunnJdoLrfvqUg2vOlpqJmqR+nH 9lHS+bEstsVJtZieU1Pa+3LzfA/4cT7XA/pnwwIDAQABo4IBtTCCAbEwDgYDVR0PAQH/BAQDAgEG MGoGA1UdJQRjMGEGCCsGAQUFBwMCBggrBgEFBQcDBAYIKwYBBQUHAwkGCisGAQQBgjcUAgIGCisG AQQBgjcKAwQGCSsGAQQBgjcVBgYKKwYBBAGCNwoDDAYIKwYBBQUHAwcGCCsGAQUFBwMRMBIGA1Ud EwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFGlygmIxZ5VEhXeRgMQENkmdewthMB8GA1UdIwQYMBaA FI/wS3+oLkUkrk1Q+mOai97i3Ru8MD4GCCsGAQUFBwEBBDIwMDAuBggrBgEFBQcwAYYiaHR0cDov L29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3RyMzA2BgNVHR8ELzAtMCugKaAnhiVodHRwOi8vY3Js Lmdsb2JhbHNpZ24uY29tL3Jvb3QtcjMuY3JsMGcGA1UdIARgMF4wCwYJKwYBBAGgMgEoMAwGCisG AQQBoDIBKAowQQYJKwYBBAGgMgFfMDQwMgYIKwYBBQUHAgEWJmh0dHBzOi8vd3d3Lmdsb2JhbHNp Z24uY29tL3JlcG9zaXRvcnkvMA0GCSqGSIb3DQEBCwUAA4IBAQConc0yzHxn4gtQ16VccKNm4iXv 6rS2UzBuhxI3XDPiwihW45O9RZXzWNgVcUzz5IKJFL7+pcxHvesGVII+5r++9eqI9XnEKCILjHr2 DgvjKq5Jmg6bwifybLYbVUoBthnhaFB0WLwSRRhPrt5eGxMw51UmNICi/hSKBKsHhGFSEaJQALZy 4HL0EWduE6ILYAjX6BSXRDtHFeUPddb46f5Hf5rzITGLsn9BIpoOVrgS878O4JnfUWQi29yBfn75 HajifFvPC+uqn+rcVnvrpLgsLOYG/64kWX/FRH8+mhVe+mcSX3xsUpcxK9q9vLTVtroU/yJUmEC4 OcH5dQsbHBqjMIIDXzCCAkegAwIBAgILBAAAAAABIVhTCKIwDQYJKoZIhvcNAQELBQAwTDEgMB4G A1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNV BAMTCkdsb2JhbFNpZ24wHhcNMDkwMzE4MTAwMDAwWhcNMjkwMzE4MTAwMDAwWjBMMSAwHgYDVQQL ExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UEAxMK R2xvYmFsU2lnbjCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMwldpB5BngiFvXAg7aE yiie/QV2EcWtiHL8RgJDx7KKnQRfJMsuS+FggkbhUqsMgUdwbN1k0ev1LKMPgj0MK66X17YUhhB5 uzsTgHeMCOFJ0mpiLx9e+pZo34knlTifBtc+ycsmWQ1z3rDI6SYOgxXG71uL0gRgykmmKPZpO/bL yCiR5Z2KYVc3rHQU3HTgOu5yLy6c+9C7v/U9AOEGM+iCK65TpjoWc4zdQQ4gOsC0p6Hpsk+QLjJg 6VfLuQSSaGjlOCZgdbKfd/+RFO+uIEn8rUAVSNECMWEZXriX7613t2Saer9fwRPvm2L7DWzgVGkW qQPabumDk3F2xmmFghcCAwEAAaNCMEAwDgYDVR0PAQH/BAQDAgEGMA8GA1UdEwEB/wQFMAMBAf8w HQYDVR0OBBYEFI/wS3+oLkUkrk1Q+mOai97i3Ru8MA0GCSqGSIb3DQEBCwUAA4IBAQBLQNvAUKr+ yAzv95ZURUm7lgAJQayzE4aGKAczymvmdLm6AC2upArT9fHxD4q/c2dKg8dEe3jgr25sbwMpjjM5 RcOO5LlXbKr8EpbsU8Yt5CRsuZRj+9xTaGdWPoO4zzUhw8lo/s7awlOqzJCK6fBdRoyV3XpYKBov Hd7NADdBj+1EbddTKJd+82cEHhXXipa0095MJ6RMG3NzdvQXmcIfeg7jLQitChws/zyrVQ4PkX42 68NXSb7hLi18YIvDQVETI53O9zJrlAGomecsMx86OyXShkDOOyyGeMlhLxS67ttVb9+E7gUJTb0o 2HLO02JQZR7rkpeDMdmztcpHWD9fMIIFRzCCBC+gAwIBAgIMW0PXrlFB5QLwO+gIMA0GCSqGSIb3 DQEBCwUAMF0xCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTMwMQYDVQQD EypHbG9iYWxTaWduIFBlcnNvbmFsU2lnbiAyIENBIC0gU0hBMjU2IC0gRzMwHhcNMjAwOTIxMTQz MTE0WhcNMjIwOTIyMTQzMTE0WjCBkDELMAkGA1UEBhMCSU4xEjAQBgNVBAgTCUthcm5hdGFrYTES MBAGA1UEBxMJQmFuZ2Fsb3JlMRYwFAYDVQQKEw1Ccm9hZGNvbSBJbmMuMRYwFAYDVQQDEw1TY290 dCBCcmFuZGVuMSkwJwYJKoZIhvcNAQkBFhpzY290dC5icmFuZGVuQGJyb2FkY29tLmNvbTCCASIw DQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALCwcSIu11LCx3EwXsMF/0Te79hG0UI3NZAsVxAh exVD4CJDTVDgpCWOXj2j4V0eOvFYcGgMNVUKtywL4OzQgNquS8/OlHQZ3/9PCq8Ox9PNkCQ5eIv1 k2UaaN0tMDke1fX++Dn0UXst0OI08PYKYJpy1mkw5Hcw28LxU5Q2HwoW/+gyOIkdSo2ovq7a9+G3 LGyQOUxLhMvko/+qqg/KTfYQJ45p6TJPcvzwA0W453P3gPRZpm54KsEIfyZiMaUBMtXsQ7dHBAla I/3RRboOeC9M13VNr5feU91O0iDoMreAgPQJ0Lo7YrodKYug0Tt/fFDjkW3v3VIbEr2liUN69U0C AwEAAaOCAdEwggHNMA4GA1UdDwEB/wQEAwIFoDCBngYIKwYBBQUHAQEEgZEwgY4wTQYIKwYBBQUH MAKGQWh0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5jb20vY2FjZXJ0L2dzcGVyc29uYWxzaWduMnNo YTJnM29jc3AuY3J0MD0GCCsGAQUFBzABhjFodHRwOi8vb2NzcDIuZ2xvYmFsc2lnbi5jb20vZ3Nw ZXJzb25hbHNpZ24yc2hhMmczME0GA1UdIARGMEQwQgYKKwYBBAGgMgEoCjA0MDIGCCsGAQUFBwIB FiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAJBgNVHRMEAjAAMEQGA1Ud HwQ9MDswOaA3oDWGM2h0dHA6Ly9jcmwuZ2xvYmFsc2lnbi5jb20vZ3NwZXJzb25hbHNpZ24yc2hh MmczLmNybDAlBgNVHREEHjAcgRpzY290dC5icmFuZGVuQGJyb2FkY29tLmNvbTATBgNVHSUEDDAK BggrBgEFBQcDBDAfBgNVHSMEGDAWgBRpcoJiMWeVRIV3kYDEBDZJnXsLYTAdBgNVHQ4EFgQUWOK7 qiyDSt/IDm/SRcNi/sTEiyswDQYJKoZIhvcNAQELBQADggEBAEe2edd4F9tpp0GPmrFrQ+xp9kY7 uxBzPdCw588bgVrPemjLwiwV37XTT4iWJtNhPfEpaguM6jeLm58LCvHq5/IBjcyHyf4URQVwAg7B pqkH8/M+IBstu4/D+znPHB59X+c+au3Q8D+xoNFd7I30kaE+oJuBuFsGXRBc0Ci+FM86x9k7SF8U aui1E7Y9wDfsRSCL2TSwU773f09WkrvVdlKxNqQZj2z7bQUUn+yfXdFfBz0LqlYNfn7xJOpQE3HI H4jq6U9+b0Qf+J0n0wyysjXPSeQ7EKXVkT8dM2KSpIN86v5dd9LkAz3C1dmjuPRGEC8ZhI1IjMBt 0itrn6C23NsxggJvMIICawIBATBtMF0xCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWdu IG52LXNhMTMwMQYDVQQDEypHbG9iYWxTaWduIFBlcnNvbmFsU2lnbiAyIENBIC0gU0hBMjU2IC0g RzMCDFtD165RQeUC8DvoCDANBglghkgBZQMEAgEFAKCB1DAvBgkqhkiG9w0BCQQxIgQguNE+FDQX BbN2rWGINYDa6MamdbmM5eXijb9nkr9Iv2swGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkq hkiG9w0BCQUxDxcNMjAxMTE2MTgwNTA0WjBpBgkqhkiG9w0BCQ8xXDBaMAsGCWCGSAFlAwQBKjAL BglghkgBZQMEARYwCwYJYIZIAWUDBAECMAoGCCqGSIb3DQMHMAsGCSqGSIb3DQEBCjALBgkqhkiG 9w0BAQcwCwYJYIZIAWUDBAIBMA0GCSqGSIb3DQEBAQUABIIBAE9rCok5GRNunHrWAK+zyOqgSb63 Hdj0h6hJE478ScT7fvhdgiSAAuqDl6sqtSa3jvhgCi1OMNfhXUuPV6uZO1Zwn71M2Y6U78yhm3Eq RtHHENvqmPHk1kg9WhgAp2c/nlZnPSiXOq56Bx4GuVxrGLio39i6VXYnV7HdxTi3lojvJn9WX5Qz Q5fE2sx1Ev8u47l+6sowhvDxt0Knad1AuAIcYW+irF1N8uqtmN4nl74BklJQU0NRRCvxbEPX+Yk1 K1bAbH5i9Ky2UAiFdNnA1S5gTBAC4z5iDUFQjobwq703ezQ7tiZjm1eo6mpz19e9kWBNzAwcRYfB Ai2hBVbztVk= --000000000000bfb7c605b43d3761--