Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Mauno Niko <niko.mauno@vaisala.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] bitbake.conf: Add comm to HOSTTOOLS
Date: Thu, 1 Feb 2018 16:39:32 +0200	[thread overview]
Message-ID: <37022525-6de2-9522-7423-70745cd5cb62@linux.intel.com> (raw)
In-Reply-To: <8812d964-49f1-b18f-751a-bcdffac028c0@vaisala.com>

On 02/01/2018 01:36 PM, Mauno Niko wrote:
>> Before we can declare that, we need to look what comm is actually used
>> for during build, and why its absence is not a problem and doesn't cause
>> errors.
>>
>> Consider also that using comm from host may break reproducibility, if
>> absence or presence of comm on the host results in a different output
>> from the build.
> 
> My patch initially did add coreutils-native to u-boot DEPENDS.
> 
> Should I resubmit it? (did not apply due to mismatch in recipe filename (version))

RP has already merged the patch you sent, I think :)

Still, in my opinion - yes, it's better to undo the HOSTTOOLS change, 
and add coreutils-native. But first, research a bit further for what 
purpose comm is used during build and why its absence doesn't break it.

Alex



  reply	other threads:[~2018-02-01 14:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29 17:47 [PATCH] bitbake.conf: Add comm to HOSTTOOLS Niko Mauno
2018-01-29 18:04 ` Manjukumar Harthikote Matha
2018-03-29 22:25   ` Denys Dmytriyenko
2018-03-29 22:55     ` Manjukumar Harthikote Matha
2018-01-30  6:38 ` Alexander Kanavin
2018-01-30  7:07   ` Khem Raj
2018-01-30 14:20     ` Alexander Kanavin
2018-02-01 11:36       ` Mauno Niko
2018-02-01 14:39         ` Alexander Kanavin [this message]
2018-02-01 14:43           ` Burton, Ross
2018-01-30 16:34     ` Manjukumar Harthikote Matha
2018-03-28 14:55 ` Luca Ceresoli
2018-03-28 15:23   ` Burton, Ross
2018-03-28 16:50     ` Luca Ceresoli
2018-03-29 22:29       ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37022525-6de2-9522-7423-70745cd5cb62@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=niko.mauno@vaisala.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox