From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Saul Wold <sgw@linux.intel.com>, Andrea Adami <andrea.adami@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] udev: update local rules for new touchscreen device
Date: Mon, 14 Oct 2013 17:19:16 +0100 [thread overview]
Message-ID: <3717106.1OZfuUGn9i@helios> (raw)
In-Reply-To: <525C152E.1040604@linux.intel.com>
Hi Saul,
On Monday 14 October 2013 09:00:46 Saul Wold wrote:
> > Andrea Adami wrote:
> >> I noticed it some time ago but the patch is still on hold....
> >> http://patchwork.openembedded.org/patch/25093/
> >
> > Thanks. I missed this. I can confirm this works for my TS device as
> > well.
>
> There was some discussion about this back then also, I would ask that
> Paul verifies that this patch is OK.
I wasn't against the original patch though; meta-handheld has had a udev
bbappend to sed this rule to exactly what the patch gives for a long time now.
Frankly I don't understand the objections in the original discussion; just
because the driver for the touchscreen doesn't provide pressure events -
either because the driver is deficient or the hardware doesn't support it - it
does not mean the device isn't a touchscreen and shouldn't be recognised as
such by udev.
Unless it is possible that the weaker rule will pick up some other non-
touchscreen device as a touchscreen as a result of this change (and I doubt
that is the case) then this patch should be applied.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-10-14 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 14:31 [PATCH] udev: update local rules for new touchscreen device Chase Maupin
2013-10-14 13:59 ` Andrea Adami
2013-10-14 14:09 ` Maupin, Chase
2013-10-14 16:00 ` Saul Wold
2013-10-14 16:19 ` Paul Eggleton [this message]
2013-10-14 16:24 ` Maupin, Chase
2013-10-14 16:35 ` Saul Wold
[not found] ` <7D46E86EC0A8354091174257B2FED101597ADD92@DLEE11.ent.ti.com>
2013-10-14 17:48 ` Andrea Adami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3717106.1OZfuUGn9i@helios \
--to=paul.eggleton@linux.intel.com \
--cc=andrea.adami@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox