From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/4] base.bbclass: Remove invalid ccache related code
Date: Mon, 10 Dec 2018 10:29:55 +0000 [thread overview]
Message-ID: <37ad7314e33e17f8d20004e609c32fb03b90dfdc.camel@linuxfoundation.org> (raw)
In-Reply-To: <bb3ede855b1af3d681a1007ccfff34be43cf6c27.1544408339.git.liezhi.yang@windriver.com>
On Sun, 2018-12-09 at 18:24 -0800, Robert Yang wrote:
> The code is in setup_hosttools_dir(), it searches ccache in PATH in
> reverse order, I can't figure out what it is used for, maybe it is
> aimed to use host's ccache rather than recipe-sysroot-
> native/usr/bin/ccache, but the later one isn't in original PATH, so
> remove the code.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> meta/classes/base.bbclass | 2 --
> 1 file changed, 2 deletions(-)
We should document it and I think its still needed.
Some distros have a "gcc" which automatically wraps ccache behind the
scenes. This code lets us find the real gcc and bypass ccache.
There would be oe-selftest failures on such a distro if we didn't do
that.
Cheers,
Richard
next prev parent reply other threads:[~2018-12-10 10:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 2:24 [PATCH 0/4] ccache.bbclass: Refactor it to make it more reliable Robert Yang
2018-12-10 2:24 ` [PATCH 1/4] base.bbclass: Remove invalid ccache related code Robert Yang
2018-12-10 10:29 ` Richard Purdie [this message]
2018-12-11 9:24 ` Robert Yang
2018-12-11 9:44 ` richard.purdie
2018-12-11 10:12 ` Robert Yang
2018-12-11 10:42 ` richard.purdie
2018-12-11 10:59 ` Yang, Liezhi
2018-12-12 2:59 ` Robert Yang
2018-12-13 3:41 ` Robert Yang
2018-12-10 2:24 ` [PATCH 2/4] ccache.bbclass: Refactor it to make it more reliable Robert Yang
2018-12-10 8:55 ` Martin Hundebøll
2018-12-11 9:18 ` Robert Yang
2018-12-13 2:47 ` Robert Yang
2018-12-10 16:16 ` Richard Purdie
2018-12-11 9:35 ` Robert Yang
2018-12-10 2:24 ` [PATCH 3/4] apr/openssl10: Enable ccache for them Robert Yang
2018-12-10 8:38 ` Martin Jansa
2018-12-11 9:15 ` Robert Yang
2018-12-10 2:24 ` [PATCH 4/4] cmake.bbclass/goarch.bbclass: Set CCACHE_DISABLE Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ad7314e33e17f8d20004e609c32fb03b90dfdc.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox