From: Khem Raj <raj.khem@gmail.com>
To: Kang Kai <Kai.Kang@windriver.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] goarch.bbclass: set SECURITY_CFLAGS for mips64
Date: Wed, 13 Jun 2018 20:33:13 -0700 [thread overview]
Message-ID: <37dc38fa-f80a-7cff-0409-b9cb72bc10e3@gmail.com> (raw)
In-Reply-To: <1ef2ee09-4f69-2a91-80f0-e700bc139e1c@windriver.com>
On 6/13/18 8:15 PM, Kang Kai wrote:
> On 2018年06月13日 22:01, Khem Raj wrote:
>> On Wed, Jun 13, 2018 at 12:16 AM <kai.kang@windriver.com> wrote:
>>> From: Kai Kang <kai.kang@windriver.com>
>>>
>>> When include conf/distro/include/security_flags.inc, NOPIE flags are
>>> still required for MIPS64 target builds. Otherwise it fails to build
>>> packages such as glide which inherit go.bbclass:
>>>
>>> |
>>> .../tmp-glibc/work/mips64-wrs-linux/glide/0.13.1-r0/recipe-sysroot-native/usr/bin/mips64-wrs-linux/../../libexec/mips64-wrs-linux/
>>>
>>> | gcc/mips64-wrs-linux/7.3.0/ld:
>>> .../tmp-glibc/work/mips64-wrs-linux/glide/0.13.1-r0/go-tmp/go-link-518447869/go.o:
>>>
>>> | relocation R_MIPS_26 against `a local symbol' can not be used when
>>> making a shared object; recompile with -fPIC`
>>>
>>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>>> ---
>>> meta/classes/goarch.bbclass | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta/classes/goarch.bbclass b/meta/classes/goarch.bbclass
>>> index f54c5169e3e..5fd9f294a8a 100644
>>> --- a/meta/classes/goarch.bbclass
>>> +++ b/meta/classes/goarch.bbclass
>>> @@ -36,6 +36,7 @@ COMPATIBLE_HOST_mipsarchn32 = "null"
>>> ARM_INSTRUCTION_SET = "arm"
>>> TUNE_CCARGS_remove = "-march=mips32r2"
>>> SECURITY_CFLAGS_mips = "${SECURITY_NOPIE_CFLAGS}"
>>> +SECURITY_CFLAGS_mips64 = "${SECURITY_NOPIE_CFLAGS}"
>> perhaps we should use _mipsall once
> Hi Khem,
>
> I don't quite follow you. It seems no such override '_mipsall' exists.
> Do you mean 'mipsarch' or something else? Thanks.
>
yes mipsarch indeed.
> Regards,
> Kai
>>
>>> SECURITY_NOPIE_CFLAGS ??= ""
>>>
>>> def go_map_arch(a, d):
>>> --
>>> 2.17.1
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
next prev parent reply other threads:[~2018-06-14 3:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 6:12 [PATCH] goarch.bbclass: set SECURITY_CFLAGS for mips64 kai.kang
2018-06-13 14:01 ` Khem Raj
2018-06-14 3:15 ` Kang Kai
2018-06-14 3:33 ` Khem Raj [this message]
2018-06-14 5:21 ` Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37dc38fa-f80a-7cff-0409-b9cb72bc10e3@gmail.com \
--to=raj.khem@gmail.com \
--cc=Kai.Kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox