public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Joao Marcos Costa <joaomarcos.costa@bootlin.com>
To: Quentin Schulz <quentin.schulz@cherry.de>,
	openembedded-core@lists.openembedded.org
Cc: thomas.petazzoni@bootlin.com
Subject: Re: [OE-core] [PATCH] meta: simplify conditional operations with bb.utils.filter
Date: Mon, 27 Apr 2026 12:53:50 +0200	[thread overview]
Message-ID: <3a7b2ce3-7cc0-4d48-8dda-5a37e1647393@bootlin.com> (raw)
In-Reply-To: <f3192818-b214-4733-82e7-4799de9f2bc6@cherry.de>

Hello again,

(...)
> 
> Yet another option is to do
> 
> (d.getVar('TUNE_CCARGS_MFPU') or '').strip() != ''
> 
> but it's a bit eww :)

I'm pretty sure that's how ERROR_QA is handled, actually:

meta/lib/oe/qa.py:    if error_class in (d.getVar("ERROR_QA") or 
"").split():

Unless this is different in a way I simply cannot see :)

> 
>> b) Simply remove those changes, then send another patch keeping only 
>> the changes in recipes.
>>
> 
> Yeah that works too. It's the same change but the implications are 
> different. So maybe three patches (one for machihes, one for QA, one for 
> recipes (maybe even in two, one for PACKAGECONFIG, one for RDEPENDS 
> since Chen Qi doesn't seem to like the latter too much :) ) so everybody 
> can bikeshed as much as they want on one and still have the rest merged :)
> 
> Cheers,
> Quentin

I'll do that. Maybe that's what I should have done in the first place, 
but I didn't want to spam N different patches that essentially do the 
same replacement.

Thanks!

-- 
Best regards,
João Marcos Costa


  reply	other threads:[~2026-04-27 10:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24 15:17 [PATCH] meta: simplify conditional operations with bb.utils.filter João Marcos Costa
2026-04-24 15:40 ` [OE-core] " Quentin Schulz
2026-04-27  8:38   ` Joao Marcos Costa
2026-04-27 10:45     ` Quentin Schulz
2026-04-27 10:53       ` Joao Marcos Costa [this message]
2026-04-27  8:49 ` ChenQi
2026-04-27  9:30   ` Joao Marcos Costa
2026-04-27 10:05     ` ChenQi
2026-04-27 11:01       ` Joao Marcos Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a7b2ce3-7cc0-4d48-8dda-5a37e1647393@bootlin.com \
    --to=joaomarcos.costa@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=quentin.schulz@cherry.de \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox