Re: [PATCH] added recipe for libdbus-c++

Burton, Ross
2016-11-15T14:23:27Z

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

On 15 November 2016 at 13:46, Thilo Cestonaro <
thilo.cestonaro@ts.fujitsu.com> wrote:

> Signed-off-by: Thilo Cestonaro <thilo.cestonaro@ts.fujitsu.com>
>

As Alex said, please submit this to meta-oe as there's no strong rationale
to keep it in oe-core, especially considering it's abandoned.

The remove_CXX_FOR_BUILD-stuff patch can be trimmed to just modify
configure.ac and tools/Makefile.am, the other files will be regenerated at
do_configure and patching them can cause conflicts if upstream ever makes a
new release.

Also please explain clearly why that has to be removed in the patch header
because usually we need to patch *in* the _FOR_BUILD macros: I was curious
and ended up looking at the build to understand why. AFAICT it's because
upstream if cross-compiling it refuses to build target tools and will only
build host tools so the test suite can run, but disabling the tests and
patching out CXX_FOR_BUILD we can build target tools. The downside is that
we have no test suite, which is useful (see the ptest class).

Thank you for being the first person in a long time to actually submit the
recipe to the community!

Ross

[-- Attachment #2: Type: text/html, Size: 1868 bytes --]