Re: [PATCH 1/3] useradd.bbclass: Fix order of postinst-useradd-*

Jermain Horsman
2024-02-23T09:10:35Z

Although I did notice the rest of the file uses this syntax,
and I do not believe there are any guidelines specific to this (that I am aware of),
I did want to comment on this.

> + if test "x$1" = "xgroup"; then

> + if test "x$1" = "xuser"; then

> + if test "x$1" = "xgroupmems"; then

As these are quotes variables the added 'x' doesn't really add anything here.

> + if test "x$1" = "x"; then

Same here, but this could just test for a zero length variable instead using 'test -z "$1"'.

Sincerely,

Jermain Horsman