From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A63C3DA59 for ; Tue, 16 Jul 2024 14:14:20 +0000 (UTC) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.groups.io with SMTP id smtpd.web10.11965.1721139256047604435 for ; Tue, 16 Jul 2024 07:14:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=dXX1gpwS; spf=pass (domain: linuxfoundation.org, ip: 209.85.221.41, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3679f806223so3865443f8f.0 for ; Tue, 16 Jul 2024 07:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1721139254; x=1721744054; darn=lists.openembedded.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=x16UbqxZMZ79ikZFuUs6w7ozO2FrPcIv5e7aGt7AF0U=; b=dXX1gpwSPjO6hGyBlC5yHoRbLw78bLOhGURDnMGsJtH68c1qoScWd+8rT21BvtIdzz a25MWGEanjy3OHaCAWNisId2f+ym7DE+YaULXiG7rgWKDdDCClB1cw5x1r7MZbUfhdmy F5eQjIvs1C/z7/XIHODqNQGYS3cqutz2J+hZQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721139254; x=1721744054; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=x16UbqxZMZ79ikZFuUs6w7ozO2FrPcIv5e7aGt7AF0U=; b=EwmEXO7c+4WyT4NagpRfCX9y9YBO+Yox2pnv2hBTnqKt3FMd6YgfVaHMaWathodwBa 4R4APHqE1/Qx18oKLZh+LJFe8hzdz1P27Nt+K61ltwEiwiYJGNGrq/z37sxMQdjOW0Rp 6kEPbgRV5OV1SspCTYRwvhq7XgjmT4Ym8aoanoQTOg57i4mE9hCb4gfFqWfM1Pljuv3x WGpidWKCWDaSw0rlEO/vPoQo8EU4WEZm92Pnkh/7kD8/V7/GUitlLEqBETtKMl+rN76J lRL0Bxa83UMRVp62OGwoEDTz1NcTd0vCV3ITqT7/u3i7rDn8j6WKT/SLRBz9cbxHyahq FPlQ== X-Gm-Message-State: AOJu0Yxmd2jW9q1MISM1aWzkXrsGKsZBgjyde3V1ybe1IUf+7S3jZWIX P2cKW1TF90ZLW+ylSxuouwegHSOZOLtiqUcUtth6/lKs0cB9uokZxp779zh63N4= X-Google-Smtp-Source: AGHT+IHvmJNNtBNK9g1YUU/raebGD+8t4xmppI9SvF+bPUPR9vzVb7olH9m9puctEOOsiUismT7Zng== X-Received: by 2002:adf:a1c4:0:b0:360:9500:9bbb with SMTP id ffacd0b85a97d-368273ed0ddmr1297268f8f.12.1721139254358; Tue, 16 Jul 2024 07:14:14 -0700 (PDT) Received: from ?IPv6:2001:8b0:aba:5f3c:86a0:3ee3:878:91c7? ([2001:8b0:aba:5f3c:86a0:3ee3:878:91c7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680dab3f2esm9220766f8f.18.2024.07.16.07.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 07:14:13 -0700 (PDT) Message-ID: <3f320d623573985d5811583fbfffa75df46befbe.camel@linuxfoundation.org> Subject: Re: [OE-core][PATCH v6 00/12] Add SPDX 3.0 support From: Richard Purdie To: Joshua Watt Cc: openembedded-core@lists.openembedded.org Date: Tue, 16 Jul 2024 15:14:13 +0100 In-Reply-To: <17E2B3F7B69CE314.18588@lists.openembedded.org> References: <20240703140059.4096394-1-JPEWhacker@gmail.com> <20240712160304.3514496-1-JPEWhacker@gmail.com> <54c574fdb35ef25b71baaf1e1adfa8bd909a5f39.camel@linuxfoundation.org> <330caeaef519ceaf40dceac15ccd00be2ed38d60.camel@linuxfoundation.org> <17E2852F1C219F3B.14505@lists.openembedded.org> <17E2B3F7B69CE314.18588@lists.openembedded.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.0-1build2 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 16 Jul 2024 14:14:20 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/202114 On Tue, 2024-07-16 at 14:18 +0100, Richard Purdie via lists.openembedded.org wrote: > On Tue, 2024-07-16 at 00:00 +0100, Richard Purdie via > lists.openembedded.org wrote: > > On Mon, 2024-07-15 at 15:26 -0600, Joshua Watt wrote: > > > On Mon, Jul 15, 2024 at 3:07=E2=80=AFPM Richard Purdie > > > wrote: > > > >=20 > > > > On Mon, 2024-07-15 at 14:40 -0600, Joshua Watt wrote: > > > > > On Sat, Jul 13, 2024 at 12:44=E2=80=AFAM Richard Purdie > > > > > wrote: > > > > > >=20 > > > > > > On Fri, 2024-07-12 at 09:58 -0600, Joshua Watt via > > > > > > lists.openembedded.org wrote: > > > > > > > This patch series add support for SPDX 3.0 and sets it as > > > > > > > the > > > > > > > default. > > > > > > > Currently it is not possible to have SPDX 2.2 and SPDX > > > > > > > 3.0 > > > > > > > enabled at > > > > > > > the same time > > > > > > >=20 > > > > > > > v2: Added tests and addressed feedback > > > > > > > v3: Fixed several oe-selftest and build failures > > > > > > > v4: Fixed silly typo mistake in staging.bbclass > > > > > > > v5: Reworked to make SPDX 3 output reproducible by > > > > > > > default. > > > > > > > Variables > > > > > > > =C2=A0=C2=A0=C2=A0 that introduce non-reproducible output are= documented > > > > > > > as > > > > > > > such. > > > > > > > v6: Many changes: > > > > > > > =C2=A0 * Fixed bug where building baremetal images would brea= k > > > > > > > SPDX > > > > > > > 2.2 > > > > > > > =C2=A0 * Most SPDX code is now in python library files instea= d > > > > > > > of > > > > > > > tasks > > > > > > > =C2=A0 * Removed dependency on pacakge_write_* tasks > > > > > > > =C2=A0 * Fixed sstate selftest cases to account for SPDX 3.0 > > > > > > > task > > > > > > > names > > > > > >=20 > > > > > > This had a lot of failures in testing I'm afraid: > > > > > >=20 > > > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/83/buil= ds/7134 > > > > >=20 > > > > > This appears to be caused because the SPDX tasks are not > > > > > running > > > > > for > > > > > some recipes (e.g. automake). It looks like this like: > > > > >=20 > > > > > =C2=A0 do_create_rootfs_spdx[recrdeptask] +=3D "do_create_spdx > > > > > do_create_package_spdx" > > > > >=20 > > > > > is not actually strong enough to make sure the SPDX tasks for > > > > > automake > > > > > run for e.g. core-image-sato-sdk, but I don't know why. I'll > > > > > keep > > > > > looking, but if anyone happens to know off the top of their > > > > > head > > > > > let > > > > > me know > > > >=20 > > > > Can you be specific about which tasks you mean when you say > > > > "make > > > > sure > > > > the SPDX tasks for automake run"? Do you mean do_create_spdx, > > > > do_create_package_spdx or a different one? > > >=20 > > > Specifically, do_create_package_spdx must be run for each package > > > installed in the rootfs before do_create_rootfs_spdx runs. I > > > thought > > > that > > >=20 > > > =C2=A0 do_create_rootfs_spdx[recrdeptask] +=3D "do_create_spdx > > > do_create_package_spdx" > > >=20 > > > would do this (the do_create_spdx is probably not necessary), > > > since > > > AFIACT, this is also how the packages get generated before being > > > installed in the root file system via manipulation of > > > do_rootfs[recrdeptask], but I think I'm missing something? > >=20 > >=20 > > In packagegroups.bbclass there is this being added: > >=20 > > do_create_package_spdx[deptask] =3D "do_create_spdx" > > do_create_package_spdx[rdeptask] =3D "" > >=20 > > and=20 > >=20 > > bitbake core-image-sato-sdk -g -c create_rootfs_spdx > >=20 > > lists > >=20 > > "core-image-sato-sdk.do_create_rootfs_spdx" -> > > "automake.do_create_package_spdx" > >=20 > > in tasks-depends.dot if I disable it. > >=20 > > I'm not 100% sure what is going on and should sleep but wanted to > > share > > that before I did. >=20 > I deleted those two lines and ran a build which passed testing. >=20 > I don't think we need them with spdx 3 since it doesn't have the > "hash > changing" issue that we had that caused us to add that for spdx2? >=20 > The commit was: > https://git.yoctoproject.org/poky/commit/meta/classes-recipe/packagegroup= .bbclass?id=3D06b5f249ced23b6bc442758131832b8640164b44 For the purposes of the archives, Joshua and I agreed we don't need these lines for SPDX 3.0. I squashed in that fix and merged SPDX 3.0 support (as default). Thanks Joshua, Marta and others for work on this. Cheers, Richard