From: richard.purdie@linuxfoundation.org
To: kai.kang@windriver.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 6/7] multilib: fix install file conflicts
Date: Thu, 06 Sep 2018 23:31:14 +0100 [thread overview]
Message-ID: <3f4638c2cbe530b8da9954ea68ae4304c78ee18d.camel@linuxfoundation.org> (raw)
In-Reply-To: <daa5eda99a0a87cd55e79dd68d7aca71c2cde746.1536248856.git.kai.kang@windriver.com>
On Thu, 2018-09-06 at 23:52 +0800, kai.kang@windriver.com wrote:
> diff --git a/meta/recipes-core/udev/eudev_3.2.5.bb b/meta/recipes-
> core/udev/eudev_3.2.5.bb
> index 75617c8d4e..75130f03ef 100644
> --- a/meta/recipes-core/udev/eudev_3.2.5.bb
> +++ b/meta/recipes-core/udev/eudev_3.2.5.bb
> @@ -23,7 +23,9 @@ SRC_URI = "http://dev.gentoo.org/~blueness/${BPN}/$
> {BP}.tar.gz \
> SRC_URI[md5sum] = "6ca08c0e14380f87df8e8aceac123671"
> SRC_URI[sha256sum] =
> "49c2d04105cad2526302627e040fa24b1916a9a3e059539bc8bb919b973890af"
>
> -inherit autotools update-rc.d qemu pkgconfig distro_features_check
> +inherit autotools update-rc.d qemu pkgconfig distro_features_check
> multilib_script
> +
> +MULTILIB_SCRIPTS = "${PN}-dev:${datadir}/pkgconfig/udev.pc"
>
> CONFLICT_DISTRO_FEATURES = "systemd"
>
> @@ -65,7 +67,7 @@ PACKAGES =+ "eudev-hwdb"
>
>
> FILES_${PN} += "${libexecdir} ${base_libdir}/udev ${bindir}/udevadm"
> -FILES_${PN}-dev = "${datadir}/pkgconfig/udev.pc \
> +FILES_${PN}-dev = "${datadir}/pkgconfig/udev.pc* \
> ${includedir}/libudev.h ${libdir}/libudev.so \
> ${includedir}/udev.h ${libdir}/libudev.la \
> ${libdir}/libudev.a
> ${libdir}/pkgconfig/libudev.pc"
I already commented on this, the file should be installed into libdir
if its arch specific. I suspect libudev.pc is, udev.pc is not and
udev.pc needs to stop referencing libdir.
Regardless, we're not using MULTILIB_SCRIPTS for .pc files.
Cheers,
Richard
next prev parent reply other threads:[~2018-09-06 22:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 15:52 [PATCH v5 0/7] disable allarch when multilib is used kai.kang
2018-09-06 15:52 ` [PATCH 1/7] allarch: only enable allarch when multilib is not used kai.kang
2018-09-13 18:20 ` Martin Jansa
2018-09-13 20:10 ` Martin Jansa
2018-09-14 11:25 ` Martin Jansa
2018-09-14 14:12 ` Martin Jansa
2018-09-17 2:25 ` Kang Kai
2018-09-17 5:50 ` Martin Jansa
2019-01-17 16:10 ` Dan Dedrick
2019-01-17 22:19 ` Richard Purdie
2018-09-06 15:52 ` [PATCH 2/7] sstate.bbclass: update SSTATE_DUPWHITELIST kai.kang
2018-09-06 15:52 ` [PATCH 3/7] update_font_cache: update script for multilib kai.kang
2018-09-06 15:52 ` [PATCH 4/7] update_gtk_immodules_cache: update " kai.kang
2018-09-06 15:52 ` [PATCH 5/7] statetests.py: drop test_sstate_allarch_samesigs_multilib kai.kang
2018-09-06 15:52 ` [PATCH 6/7] multilib: fix install file conflicts kai.kang
2018-09-06 22:31 ` richard.purdie [this message]
2018-09-07 1:22 ` Kang Kai
2018-09-06 15:52 ` [PATCH 7/7] target-sdk-provides-dummy: skip package_qa_multilib check kai.kang
2018-09-06 17:04 ` ✗ patchtest: failure for disable allarch when multilib is used Patchwork
2018-09-07 8:32 ` [PATCH v5 0/7] " richard.purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f4638c2cbe530b8da9954ea68ae4304c78ee18d.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox