Openembedded Core Discussions
 help / color / mirror / Atom feed
From: ChenQi <Qi.Chen@windriver.com>
To: Patrick Ohly <patrick.ohly@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/4] initscripts: support persistent /var/log
Date: Tue, 13 Dec 2016 16:00:11 +0800	[thread overview]
Message-ID: <3fb4f7c8-66d3-60b3-8d2d-60934f648e94@windriver.com> (raw)
In-Reply-To: <1481529942.17535.198.camel@intel.com>

On 12/12/2016 04:05 PM, Patrick Ohly wrote:
> On Tue, 2016-11-22 at 18:10 +0800, Chen Qi wrote:
>> ${WORKDIR}/volatiles         ${D}${sysconfdir}/default/volatiles/00_core
>> +       if [ "${VOLATILE_LOG_DIR}" = "log" ]; then
>> +               echo "l root root 0755 /var/log /var/volatile/log" >>
>> ${D}${sysconfdir}/default/volatiles/00_core
>> +       fi
> Why are you checking for "log" here? I thought VOLATILE_LOG_DIR was
> supposed to be a boolean?
>
> Using oe.types.boolean in shell code is a bit awkward, but would be
> necessary for the sake of consistency when allowing VOLATILE_LOG_DIR to
> have more than just yes/no. Untested (relies on bool->str conversion):
>
> if [ ${@ oe.types.boolean('${VOLATILE_LOG_DIR}') } = True ]; then
>

Thanks for your suggestion.

I'll send out V2.

Best Regards,

Chen Qi



  reply	other threads:[~2016-12-13  7:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 10:10 [PATCH 0/4] Persistent /var/log support Chen Qi
2016-11-22 10:10 ` [PATCH 1/4] bitbake.conf: add VOLATILE_LOG_DIR variable Chen Qi
2016-11-22 10:10 ` [PATCH 2/4] base-files: respect VOLATILE_LOG_DIR Chen Qi
2016-12-12  8:01   ` Patrick Ohly
2016-11-22 10:10 ` [PATCH 3/4] initscripts: support persistent /var/log Chen Qi
2016-12-12  8:05   ` Patrick Ohly
2016-12-13  8:00     ` ChenQi [this message]
2016-11-22 10:10 ` [PATCH 4/4] package.bbclass: " Chen Qi
2016-11-29 10:28 ` [PATCH 0/4] Persistent /var/log support Jack Mitchell
  -- strict thread matches above, loose matches on Subject: below --
2017-08-16 11:57 [PATCH V4 " Chen Qi
2017-08-16 11:57 ` [PATCH 3/4] initscripts: support persistent /var/log Chen Qi
2015-03-24  8:42 [PATCH 0/4] Support " Chen Qi
2015-03-24  8:42 ` [PATCH 3/4] initscripts: support " Chen Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fb4f7c8-66d3-60b3-8d2d-60934f648e94@windriver.com \
    --to=qi.chen@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=patrick.ohly@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox