From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Alexander Kanavin <alex.kanavin@gmail.com>,
Joe Slater <joe.slater@windriver.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>,
Randy MacLeod <randy.macleod@windriver.com>
Subject: Re: [oe-core][PATCH 1/1] blktrace: change shebangs
Date: Mon, 16 Aug 2021 22:59:14 +0100 [thread overview]
Message-ID: <3fd323f691fe9f1a8786e811bf3253fe9aaebba1.camel@linuxfoundation.org> (raw)
In-Reply-To: <CANNYZj9xLN5vDQ5vgHk1S7k8PfX_zM1+ThzfVF+Yw+Y4aQrpMA@mail.gmail.com>
On Mon, 2021-08-16 at 20:40 +0200, Alexander Kanavin wrote:
> On Mon, 16 Aug 2021 at 20:20, Joe Slater <joe.slater@windriver.com> wrote:
> > +blktrace can use either python2 or python3, but we really want
> > +python3, so modify the shebangs.
> > +
> > +Upstream-Status: pending
> > +
> > +Signed-off-by: Joe Slater <joe.slater@windriver.com.
> >
>
>
> Please submit upstream first. Signed-off-by is incorrectly written,
> needs to be added by git preferably. 'Pending' needs to be capitalized
> (but please submit upstream first).
I very much doubt upstream will want to change "python" -> "python3" as it
is a distro thing. It is frustrating it isn't configurable. I think in most
other cases we sed this into scripts but that has pros and cons too rather
than a patch we have to carry...
Cheers,
Richard
next prev parent reply other threads:[~2021-08-16 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 18:20 [oe-core][PATCH 1/1] blktrace: change shebangs Joe Slater
2021-08-16 18:40 ` Alexander Kanavin
2021-08-16 21:59 ` Richard Purdie [this message]
2021-08-17 16:07 ` Joe Slater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fd323f691fe9f1a8786e811bf3253fe9aaebba1.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alex.kanavin@gmail.com \
--cc=joe.slater@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=randy.macleod@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox