From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: argh ... "_append" versus "+=" and IMAGE_INSTALL confusion
Date: Thu, 29 Mar 2012 21:42:08 +0100 [thread overview]
Message-ID: <4067879.36leZStCMh@helios> (raw)
In-Reply-To: <alpine.DEB.2.02.1203291533390.5968@oneiric>
On Thursday 29 March 2012 15:35:10 Robert P. J. Day wrote:
> On Thu, 29 Mar 2012, Eric Bénard wrote:
> > Le Thu, 29 Mar 2012 15:23:20 -0400 (EDT),
> >
> > "Robert P. J. Day" <rpjday@crashcourse.ca> a écrit :
> > > so what is best practise here?
> >
> > for this one you have an answer on OE's wiki :
> > http://www.openembedded.org/wiki/I_want_an_image_with_package_XYZ_installe
> > d
>
> despite the fact that the current reference manual *explicitly*
> says this?
>
> "Using IMAGE_INSTALL with the += operator from the /conf/local.conf
> file or from within an image recipe is not recommended as it can cause
> ordering issues."
I think what the manual is attempting to mitigate is a situation where you do
the following in your image recipe:
-------- snip -------
IMAGE_INSTALL += "somepackage1 somepackage2"
inherit core-image
-------- snip -------
In this instance, because IMAGE_INSTALL is set via ?= within core-
image.bbclass, IMAGE_INSTALL will only be set to "somepackage1 somepackage2"
since the value is already set by the time it gets to the ?=. This is clearly
not what you would want by using +=.
Doing the following in an image recipe will work properly however:
-------- snip -------
inherit core-image
IMAGE_INSTALL += "somepackage1 somepackage2"
-------- snip -------
Personally I think the text you quoted from the manual should be adjusted;
there's nothing wrong with IMAGE_INSTALL += _in an image recipe_ provided that
you do it _after_ the inherit of core-image.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-03-29 20:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 19:23 argh ... "_append" versus "+=" and IMAGE_INSTALL confusion Robert P. J. Day
2012-03-29 19:29 ` Eric Bénard
2012-03-29 19:35 ` Robert P. J. Day
2012-03-29 19:39 ` Eric Bénard
2012-03-29 19:42 ` Chris Larson
2012-03-29 19:49 ` Robert P. J. Day
2012-03-29 20:42 ` Paul Eggleton [this message]
2012-03-30 10:23 ` Robert P. J. Day
2012-03-30 10:52 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4067879.36leZStCMh@helios \
--to=paul.eggleton@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox