Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Steve Sakoman <steve@sakoman.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][mickledore 05/15] glib-networking: Correct glib error handling in test patch
Date: Sun, 14 May 2023 22:49:33 +0100	[thread overview]
Message-ID: <4138a44fc28eaecc2feb86dcec97b04c8aeb4e0a.camel@linuxfoundation.org> (raw)
In-Reply-To: <66dc4b94e9fad8d209f12fa64bd0673a42c28ac9.1684081748.git.steve@sakoman.com>

On Sun, 2023-05-14 at 06:31 -1000, Steve Sakoman wrote:
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (cherry picked from commit 4ba74f61f38827d82586cf9c993a4b27065f5c6f)
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>  meta/recipes-core/glib-networking/glib-networking/eagain.patch | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/glib-networking/glib-networking/eagain.patch b/meta/recipes-core/glib-networking/glib-networking/eagain.patch
> index 6dfbb2736c..ac6592ffef 100644
> --- a/meta/recipes-core/glib-networking/glib-networking/eagain.patch
> +++ b/meta/recipes-core/glib-networking/glib-networking/eagain.patch
> @@ -21,7 +21,7 @@ Index: glib-networking-2.74.0/tls/tests/connection.c
>                                      MIN (TEST_DATA_LENGTH / 2, TEST_DATA_LENGTH - test->nread),
>                                      NULL, &error);
>  +
> -+      if (error == G_IO_STATUS_AGAIN)
> ++      if (g_error_matches (error, G_IO_ERROR, G_IO_ERROR_BUSY))
>  +          continue;
>  +
>         g_assert_no_error (error);

I'm not sure this is working yet, I suspect we've seen the error in
builds with the patch applied :(

Cheers,

Richard


  reply	other threads:[~2023-05-14 21:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-14 16:31 [OE-core][mickledore 00/15] Patch review Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 01/15] waffle: upgrade 1.7.0 -> 1.7.2 Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 02/15] mesa: 23.0.2 -> 23.0.3 Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 03/15] qemu: Update ppc instruction fix to match revised upstream version Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 04/15] glib-networking: Add test retry to avoid failures Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 05/15] glib-networking: Correct glib error handling in test patch Steve Sakoman
2023-05-14 21:49   ` Richard Purdie [this message]
2023-05-14 21:54     ` Steve Sakoman
2023-05-17  8:11       ` Richard Purdie
2023-05-17 13:51         ` Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 06/15] gawk: Disable known ptest fails on musl Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 07/15] gawk: Remove redundant patch Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 08/15] gawk: Add skipped.txt to emit test to ignore Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 09/15] libxml2: Disable icu tests on musl Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 10/15] maintainers.inc: Fix email address typo Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 11/15] cpio: fix appending to archives larger than 2GB Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 12/15] systemd-systemctl: fix instance template WantedBy symlink construction Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 13/15] populate_sdk_ext.bbclass: redirect stderr to stdout so that both end in LOGFILE Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 14/15] maintainers.inc: Move repo to unassigned Steve Sakoman
2023-05-14 16:31 ` [OE-core][mickledore 15/15] machine/qemuarm*: don't explicitly set vmalloc Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4138a44fc28eaecc2feb86dcec97b04c8aeb4e0a.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=steve@sakoman.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox