Re: [OE-core] [PATCH] pango: Restore the install tests for pango

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sun, 2025-01-19 at 23:33 +0800, Song, Jiaying (CN) via lists.openembedded.org wrote:
> From: Jiaying Song <jiaying.song.cn@windriver.com>
> 
> Upstream removed the install-test and left only the build-test
> option,but this cannot be tested on the target. Therefore, the
> install-test is restored using the patch provided by upstream:
> https://salsa.debian.org/gnome-team/pango/-/blob/debian/latest/debian/patches/Revert-build-Drop-the-install-tests-option.patch
> 
> Related discussions and commits:
> https://gitlab.gnome.org/GNOME/pango/-/issues/799
> https://gitlab.gnome.org/GNOME/pango/-/commit/2c637453aa1ece7daa9c477b95b20d993c70ab4e
> https://gitlab.gnome.org/GNOME/pango/-/commit/927abccf371cd823b185a6df98d871d12601220a
> 
> Partial test log:
> # Start of break tests
> ok 1 /text/break/grapheme
> ok 2 /text/break/word
> ok 3 /text/break/sentence
> ok 4 /text/break/line # SKIP Test file not found
> ok 5 /text/break/emoji
> ok 6 /text/break/char
> # End of break tests
> # End of text tests
> PASS: pango/testboundaries_ucd.test
> SUMMARY: total=27; passed=27; skipped=0; failed=0; user=29.6s; system=18.0s; maxrss=35328
> 
> Signed-off-by: Jiaying Song <jiaying.song.cn@windriver.com>
> ---
>  .../distro/include/ptest-packagelists.inc     |   1 +
>  ...-build-Drop-the-install-tests-option.patch | 316 ++++++++++++++++++
>  meta/recipes-graphics/pango/pango/run-ptest   |   6 +
>  meta/recipes-graphics/pango/pango_1.55.5.bb   |  16 +-
>  4 files changed, 337 insertions(+), 2 deletions(-)
>  create mode 100644 meta/recipes-graphics/pango/pango/0001-Revert-build-Drop-the-install-tests-option.patch
>  create mode 100644 meta/recipes-graphics/pango/pango/run-ptest
> 
> diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
> index e2a90c1c2ef..e01b7a3c346 100644
> --- a/meta/conf/distro/include/ptest-packagelists.inc
> +++ b/meta/conf/distro/include/ptest-packagelists.inc
> @@ -85,6 +85,7 @@ PTESTS_FAST = "\
>      wayland \
>      xz \
>      zlib \
> +    pango \
>  "
>  PTESTS_FAST:append:libc-glibc = " glibc-y2038-tests"
>  PTESTS_PROBLEMS:remove:libc-glibc = "glibc-y2038-tests"
> diff --git a/meta/recipes-graphics/pango/pango/0001-Revert-build-Drop-the-install-tests-option.patch b/meta/recipes-graphics/pango/pango/0001-Revert-build-Drop-the-install-tests-option.patch
> new file mode 100644
> index 00000000000..42e94422cc1
> --- /dev/null
> +++ b/meta/recipes-graphics/pango/pango/0001-Revert-build-Drop-the-install-tests-option.patch
> @@ -0,0 +1,316 @@
> +From 2e8c8aee4dc7cc069afaec3a2caaeeaa73d5b0ce Mon Sep 17 00:00:00 2001
> +From: =?UTF-8?q?Jeremy=20B=C3=ADcha?= <jeremy.bicha@canonical.com>
> +Date: Mon, 10 Jun 2024 08:52:56 -0400
> +Subject: [PATCH] Revert "build: Drop the install-tests option"
> +
> +This reverts commit 2c637453aa1ece7daa9c477b95b20d993c70ab4e.
> +
> +Closes: https://gitlab.gnome.org/GNOME/pango/-/issues/799
> +
> +Upstream-Status: Backport [https://salsa.debian.org/gnome-team/pango/-/blob/debian/latest/debian/patches/Revert-build-Drop-the-install-tests-option.patch]
> +Signed-off-by: Jiaying Song <jiaying.song.cn@windriver.com>

If it was not merged into the main upstream development branch, it is
not a backport. As far as I know this is Rejected upstream.

Cheers,

Richard