Re: [OE-core] [PATCH 1/1] wpa-supplicant: fix sed expression

[Paul Barker <paul@pbarker.dev>]

[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]

On Fri, 2025-12-19 at 05:56 -0800, vishal.gupta_1 via
lists.openembedded.org wrote:
> Hi Alexander,
> 
> In the do_configure function current intention of implementation is to first delete it when we copying and then depending on the PACKAGECONFIG assign it with correct value.
> As delete is failed because the line start with "#" we will have two CONFIG_TLS value in final ".config" file
> 
> one, at some where middle of the file
> #CONFIG_TLS=openssl
> 
> second, depending on package config, at the end of file as it's an append operation.
> CONFIG_TLS=openssl / gnutls
> 
> do_configure () {
> ${MAKE} -C wpa_supplicant clean
> sed -e '/^#\?CONFIG_TLS=/d' <wpa_supplicant/defconfig >wpa_supplicant/.config
> if ${@ bb.utils.contains('PACKAGECONFIG', 'openssl', 'true', 'false', d) }; then
> echo 'CONFIG_TLS=openssl' >>wpa_supplicant/.config
> elif ${@ bb.utils.contains('PACKAGECONFIG', 'gnutls', 'true', 'false', d) }; then
> echo 'CONFIG_TLS=gnutls' >>wpa_supplicant/.config
> sed -i -e 's/\(^CONFIG_DPP=\)/#\1/' \
> -e 's/\(^CONFIG_EAP_PWD=\)/#\1/' \
> -e 's/\(^CONFIG_SAE=\)/#\1/' wpa_supplicant/.config
> fi
> 
> So with this change there will be only one "CONFIG_TLS=<value>" option.

Looking at the wpa_supplicant README file [1]:

  Configuration options are text lines using following
  format: CONFIG_<option>=y. Lines starting with # are considered
  comments and are ignored.

[1]: https://git.w1.fi/cgit/hostap/tree/wpa_supplicant/README

So, leaving the comment line with the default CONFIG_TLS value isn't a
problem.

Best regards,

-- 
Paul Barker


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 252 bytes --]