From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mail.openembedded.org (Postfix) with ESMTP id 4832F781D3 for ; Fri, 14 Jul 2017 15:26:51 +0000 (UTC) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jul 2017 08:26:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,359,1496127600"; d="scan'208";a="126725843" Received: from alimonb-mobl1.zpn.intel.com (HELO [10.219.128.139]) ([10.219.128.139]) by fmsmga005.fm.intel.com with ESMTP; 14 Jul 2017 08:26:48 -0700 To: Patrick Ohly References: <27730e7982a21e192eaba5ab975ca8afd4105e0f.1499803885.git.anibal.limon@linux.intel.com> <1500025974.21921.38.camel@intel.com> From: =?UTF-8?B?QW7DrWJhbCBMaW3Ds24=?= Message-ID: <4317db53-7822-9b8a-c614-b925ee05bfce@linux.intel.com> Date: Fri, 14 Jul 2017 10:27:14 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1500025974.21921.38.camel@intel.com> Cc: joshua.g.lock@intel.com, openembedded-core@lists.openembedded.org Subject: Re: [PATCH 01/30] oeqa/core/loader: Switch method definition for _make_failed_test X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2017 15:26:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 07/14/2017 04:52 AM, Patrick Ohly wrote: > On Tue, 2017-07-11 at 15:23 -0500, Aníbal Limón wrote: >> This was a mistake of me to define wrong what methods needs >> to be defined by certain python version. >> >> See rev d8380d098a290510b442a7abd2dd5a50cabf5844. > > This will fix this error that we see in Refkit with current OE-core > master, right? > > 00:07:10.313 Traceback (most recent call last): > 00:07:10.313 File "/srv/jenkins/workspace/ci-2017-07-14_01-48-19-build-2315/openembedded-core/scripts/oe-selftest", line 70, in > 00:07:10.313 ret = main() > 00:07:10.313 File "/srv/jenkins/workspace/ci-2017-07-14_01-48-19-build-2315/openembedded-core/scripts/oe-selftest", line 57, in main > 00:07:10.313 results = args.func(logger, args) > 00:07:10.313 File "/srv/jenkins/workspace/ci-2017-07-14_01-48-19-build-2315/openembedded-core/meta/lib/oeqa/selftest/context.py", line 215, in run > 00:07:10.313 rc = self._internal_run(logger, args) > 00:07:10.313 File "/srv/jenkins/workspace/ci-2017-07-14_01-48-19-build-2315/openembedded-core/meta/lib/oeqa/selftest/context.py", line 176, in _internal_run > 00:07:10.313 self.tc.loadTests(self.module_paths, **self.tc_kwargs['load']) > 00:07:10.313 File "/srv/jenkins/workspace/ci-2017-07-14_01-48-19-build-2315/openembedded-core/meta/lib/oeqa/core/context.py", line 51, in loadTests > 00:07:10.313 self.suites = self.loader.discover() > 00:07:10.313 File "/srv/jenkins/workspace/ci-2017-07-14_01-48-19-build-2315/openembedded-core/meta/lib/oeqa/core/loader.py", line 286, in discover > 00:07:10.313 pattern='*.py', top_level_dir=path) > 00:07:10.313 File "/usr/lib64/python3.4/unittest/loader.py", line 275, in discover > 00:07:10.313 tests = list(self._find_tests(start_dir, pattern)) > 00:07:10.313 File "/usr/lib64/python3.4/unittest/loader.py", line 327, in _find_tests > 00:07:10.313 yield _make_failed_import_test(name, self.suiteClass) > 00:07:10.313 File "/usr/lib64/python3.4/unittest/loader.py", line 39, in _make_failed_import_test > 00:07:10.313 return _make_failed_test(name, ImportError(message), suiteClass) > 00:07:10.313 TypeError: _make_failed_test() missing 1 required positional argument: 'suiteClass' > > Can this particular patch please be merged into OE-core master > independently from the patch series? It's not really related to it > anyway. Yes this will fix that error, showing the error into the case. By default unittest module shows this kind of error at run step so it's better for us to notice when a test case have syntax or modules missing errors at load step. Cheers, Anibal >