Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Martin Jansa <martin.jansa@gmail.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] patch.py: Use git format-patch with --no-signature --no-numbered params
Date: Fri, 16 Mar 2018 12:37:24 +0200	[thread overview]
Message-ID: <43bf1dcc-afc2-53ca-34c1-57b2d2e1d810@linux.intel.com> (raw)
In-Reply-To: <20180315225010.48-1-Martin.Jansa@gmail.com>

On 03/16/2018 12:50 AM, Martin Jansa wrote:
> * --no-signature saves unnecessary .patch modifications when executed on
>    host with different git version
> * --no-numbered saves unnecessary .patch modifications when number of the
>    applied patches is changed (the number is still in the filename so the
>    order how they should be applied is still preserved)
> * both options exist for very long time, I've tested them with git 1.9.1
>    from Ubuntu 14.04 and I'm quite sure they were available even in much
>    older releases, so there shouldn't be any issue on relatively new sanity
>    tested distros

Thanks, this should reduce the churn. By the way, when reviewing a 
change to a patch, it is *far* easier to look at it with a side by side 
diff tool than the usual +- format. I use vscode with gitlens extension 
(can't believe I am recommending a Microsoft product, but here we are).

Alex


  reply	other threads:[~2018-03-16 10:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 22:50 [PATCH] patch.py: Use git format-patch with --no-signature --no-numbered params Martin Jansa
2018-03-16 10:37 ` Alexander Kanavin [this message]
2018-03-16 19:21   ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43bf1dcc-afc2-53ca-34c1-57b2d2e1d810@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox