From: Daniel Turull <daniel.turull@ericsson.com>
To: "Ross.Burton@arm.com" <Ross.Burton@arm.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>,
"richard.purdie@linuxfoundation.org"
<richard.purdie@linuxfoundation.org>
Subject: Re: [OE-core] [PATCH v2 2/3] devtool: upgrade: read changelog blobs via a temp file
Date: Thu, 6 Aug 2026 14:09:42 +0000 [thread overview]
Message-ID: <441b84ff90768959e5ff1375d00e18969f53d6b9.camel@ericsson.com> (raw)
In-Reply-To: <11EBBEC5-8521-40C3-81E6-A9E86B2A4A1C@arm.com>
On Thu, 2026-08-06 at 14:05 +0000, Ross Burton wrote:
> On 4 Aug 2026, at 07:06, Daniel Turull via lists.openembedded.org
> <daniel.turull=ericsson.com@lists.openembedded.org> wrote:
> > The alternative to use a tmp file was to modify _run to allow other encodings than utf-8, but it
> > will be a bigger refactor. Or not use _run and call directly the raw subprocess calls.
> >
> > I can change it to either option or keep the current patch.
>
> bb.process.run() is meant for use by bitbake itself, it’s a glorified/bad wrapper around
> subprocess.run() that just does some logging magic whilst also getting in the way and doing things
> like forcing utf-8... That magic isn’t useful in devtool, so I think we should be calling
> subprocess.run() directly.
>
> Ross
ok. I'll change it to that. It was one one of the options that I had in mind but I was not sure if
we wanted to have all going to run()
Thanks Ross.
Daniel
prev parent reply other threads:[~2026-08-06 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 6:02 [PATCH v2 0/3] devtool: upgrade: improve changelog extraction for git-log-style ChangeLogs daniel.turull
2026-08-04 6:02 ` [PATCH v2 1/3] devtool: upgrade: ignore changelogs from 3rd party daniel.turull
2026-08-04 6:02 ` [PATCH v2 2/3] devtool: upgrade: read changelog blobs via a temp file daniel.turull
2026-08-04 6:02 ` [PATCH v2 3/3] devtool: upgrade: diff git-log-style changelogs by commit hash daniel.turull
[not found] ` <18C884DEFF3686EE.1990914@lists.openembedded.org>
2026-08-04 6:06 ` [OE-core] [PATCH v2 2/3] devtool: upgrade: read changelog blobs via a temp file Daniel Turull
2026-08-06 14:05 ` Ross Burton
2026-08-06 14:09 ` Daniel Turull [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=441b84ff90768959e5ff1375d00e18969f53d6b9.camel@ericsson.com \
--to=daniel.turull@ericsson.com \
--cc=Ross.Burton@arm.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox