Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Changqing Li <changqing.li@windriver.com>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] openssl: change make install run serially
Date: Thu, 25 Oct 2018 13:10:45 +0800	[thread overview]
Message-ID: <4572e29a-3b92-745d-b794-20e514b961a8@windriver.com> (raw)
In-Reply-To: <CAJ86T=Unn7MyQ5jvuuBefA2EfbYprUbkmSVG_9BQBW4+7ej0sg@mail.gmail.com>



On 10/25/2018 12:59 PM, Andre McCurdy wrote:
> On Wed, Oct 24, 2018 at 9:18 PM,  <changqing.li@windriver.com> wrote:
>> From: Changqing Li <changqing.li@windriver.com>
>>
>> openssl offcially don't supprt parallel make install, and have
>> occasionally install fail problem for parallel build,
>> according to upstream suggestion, just make install serially.
>>
>> refer:
>> https://github.com/openssl/openssl/issues/7466#issuecomment-432148137
> Wouldn't setting PARALLEL_MAKEINST be cleaner than patching the Makefile?

You are right, I will resend the patch.
>
>> Signed-off-by: Changqing Li <changqing.li@windriver.com>
>> ---
>>   ...nssl-let-make-install-stop-parallel-build.patch | 37 ++++++++++++++++++++++
>>   meta/recipes-connectivity/openssl/openssl_1.1.1.bb |  1 +
>>   2 files changed, 38 insertions(+)
>>   create mode 100644 meta/recipes-connectivity/openssl/openssl/0001-openssl-let-make-install-stop-parallel-build.patch
>>
>> diff --git a/meta/recipes-connectivity/openssl/openssl/0001-openssl-let-make-install-stop-parallel-build.patch b/meta/recipes-connectivity/openssl/openssl/0001-openssl-let-make-install-stop-parallel-build.patch
>> new file mode 100644
>> index 0000000..0726d04
>> --- /dev/null
>> +++ b/meta/recipes-connectivity/openssl/openssl/0001-openssl-let-make-install-stop-parallel-build.patch
>> @@ -0,0 +1,37 @@
>> +From adb36f6dadecf8775cf9603ee4745aed6ee20af1 Mon Sep 17 00:00:00 2001
>> +From: Changqing Li <changqing.li@windriver.com>
>> +Date: Thu, 25 Oct 2018 09:43:48 +0800
>> +Subject: [PATCH] openssl: let make install stop parallel build
>> +
>> +openssl offcially don't supprt parallel make install, and have
>> +occasionally install fail problem for parallel build,
>> +according to upstream suggestion, just make install serially.
>> +
>> +refer:
>> +https://github.com/openssl/openssl/issues/7466#issuecomment-432148137
>> +
>> +Upstream-Status: Inappropriate[oe-specific]
>> +
>> +Signed-off-by: Changqing Li <changqing.li@windriver.com>
>> +---
>> + Configurations/unix-Makefile.tmpl | 4 ++++
>> + 1 file changed, 4 insertions(+)
>> +
>> +diff --git a/Configurations/unix-Makefile.tmpl b/Configurations/unix-Makefile.tmpl
>> +index 16af4d2..c8f60df 100644
>> +--- a/Configurations/unix-Makefile.tmpl
>> ++++ b/Configurations/unix-Makefile.tmpl
>> +@@ -437,6 +437,10 @@ depend:
>> +
>> + # Install helper targets #############################################
>> +
>> ++ifneq ($(filter install,$(MAKECMDGOALS)),)
>> ++.NOTPARALLEL:
>> ++endif
>> ++
>> + install_sw: all install_dev install_engines install_runtime
>> +
>> + uninstall_sw: uninstall_runtime uninstall_engines uninstall_dev
>> +--
>> +2.7.4
>> +
>> diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1.bb b/meta/recipes-connectivity/openssl/openssl_1.1.1.bb
>> index af9038a..8330162 100644
>> --- a/meta/recipes-connectivity/openssl/openssl_1.1.1.bb
>> +++ b/meta/recipes-connectivity/openssl/openssl_1.1.1.bb
>> @@ -15,6 +15,7 @@ SRC_URI = "http://www.openssl.org/source/openssl-${PV}.tar.gz \
>>              file://run-ptest \
>>              file://openssl-c_rehash.sh \
>>              file://0001-skip-test_symbol_presence.patch \
>> +           file://0001-openssl-let-make-install-stop-parallel-build.patch \
>>              "
>>
>>   SRC_URI_append_class-nativesdk = " \
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
BRs

Sandy(Li Changqing)
Wind River Linux



  reply	other threads:[~2018-10-25  5:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25  4:18 [PATCH] openssl: change make install run serially changqing.li
2018-10-25  4:59 ` Andre McCurdy
2018-10-25  5:10   ` Changqing Li [this message]
2018-10-25 12:44     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4572e29a-3b92-745d-b794-20e514b961a8@windriver.com \
    --to=changqing.li@windriver.com \
    --cc=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox