public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Yannic Moog <Y.Moog@phytec.de>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	Alexander Kanavin <alex@linutronix.de>,
	"upstream@lists.phytec.de" <upstream@lists.phytec.de>
Subject: Re: [OE-core] [PATCH] icu: split at '.' instead of '-' for major version
Date: Tue, 13 Jan 2026 12:42:43 +0000	[thread overview]
Message-ID: <458f839bc4a7f231cf4c1a8ea442bbcd5601a353.camel@phytec.de> (raw)
In-Reply-To: <CANNYZj90X_vSfAhUAVhiik+RNKSydLMD8iv_AoRHUAm1TQSjzQ@mail.gmail.com>

On Tue, 2026-01-13 at 11:43 +0100, Alexander Kanavin wrote:
> On Tue, 13 Jan 2026 at 09:27, Yannic Moog via lists.openembedded.org
> <y.moog=phytec.de@lists.openembedded.org> wrote:
> > With version 78.1, icu adopted '.' as separator between major and minor
> > version. With the upgrade commit, ICU_MAJOR_VER wasn't updated and still
> > tried to split versions with '-' instead of '.'. Fix by using '.' as
> > separator.
> > -ICU_MAJOR_VER = "${@d.getVar('PV').split('-')[0]}"
> > +ICU_MAJOR_VER = "${@d.getVar('PV').split('.')[0]}"
> 
> Presumably this change comes from build problems you are observing,
> but it doesn't explain why plain poky is building fine without this
> fix. Can you look into that please?

Yep. I was mistaken initially. The task that failed for me is the do_make_icudata.

Within that task, the last command fails:

do_make_icudata:class-target () {
    ${@bb.utils.contains('PACKAGECONFIG', 'make-icudata', '', 'exit 0', d)}
    [...]
    install -Dm644 ${S}/data/out/icudt${ICU_MAJOR_VER}l.dat ${S}/data/in/icudt${ICU_MAJOR_VER}l.dat
}

We do not see it with poky, because PACKAGECONFIG does not contain make-icudata.
We have the following in a bbappend of our distro layer:

FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
SRC_URI += "file://filter.json"
PACKAGECONFIG += "make-icudata"
PACKAGECONFIG:pn-icu-native += " make-icudata"

which triggers the error.

Yannic

> 
> Alex

  reply	other threads:[~2026-01-13 12:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  8:27 [PATCH] icu: split at '.' instead of '-' for major version Yannic Moog
2026-01-13 10:43 ` [OE-core] " Alexander Kanavin
2026-01-13 12:42   ` Yannic Moog [this message]
2026-01-13 15:19     ` Alexander Kanavin
2026-01-14  8:07       ` Yannic Moog

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=458f839bc4a7f231cf4c1a8ea442bbcd5601a353.camel@phytec.de \
    --to=y.moog@phytec.de \
    --cc=alex.kanavin@gmail.com \
    --cc=alex@linutronix.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=upstream@lists.phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox