From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Ciprian Ciubotariu <cheepeero@gmx.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] packagroup-base: use virtual runtime instead of keymap
Date: Tue, 11 Dec 2012 09:30:53 +0000 [thread overview]
Message-ID: <4610754.7ihuexEZvz@helios> (raw)
In-Reply-To: <6320134.5f19h5zvPL@helios>
On Tuesday 11 December 2012 09:28:47 Paul Eggleton wrote:
> On Tuesday 11 December 2012 10:18:41 Martin Jansa wrote:
> > On Fri, Dec 07, 2012 at 04:44:15PM +0200, Ciprian Ciubotariu wrote:
> > > ---
> > >
> > > .../packagegroups/packagegroup-base.bb | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > b/meta/recipes-core/packagegroups/packagegroup-base.bb index
> > > 347a7e1..3e75190 100644
> > > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > @@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base =
> > > "${MACHINE_EXTRA_RRECOMMENDS}">
> > >
> > > SUMMARY_packagegroup-base-keyboard = "Keyboard support"
> > > RDEPENDS_packagegroup-base-keyboard = "\
> > >
> > > - keymaps"
> > > + ${VIRTUAL-RUNTIME_keymaps}"
> >
> > you need to specify default value with weak assignment like
> > packagegroup-core-boot.bb does
>
> Also, could you please include a commit message explaining why this is
> needed?
Ah, well; not so much why this is needed but explaining that this makes it
consistent with packagegroup-core-boot.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-11 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 14:44 [PATCH] packagroup-base: use virtual runtime instead of keymap Ciprian Ciubotariu
2012-12-11 9:18 ` Martin Jansa
2012-12-11 9:28 ` Paul Eggleton
2012-12-11 9:30 ` Paul Eggleton [this message]
2012-12-15 0:50 ` [PATCH v2] packagegroup-base: " Ciprian Ciubotariu
2012-12-15 6:59 ` Martin Jansa
2012-12-18 7:04 ` packagegroup-base notes Ciprian Ciubotariu
2012-12-18 7:04 ` [PATCH v3] packagegroup-base: use virtual runtime instead of keymap Ciprian Ciubotariu
2012-12-18 9:03 ` packagegroup-base notes Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4610754.7ihuexEZvz@helios \
--to=paul.eggleton@linux.intel.com \
--cc=cheepeero@gmx.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox