From: "Manuel Leonhardt" <mleonhardt@arri.de>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v4 0/4] cmake.bbclass improvements
Date: Fri, 13 Dec 2024 12:46:09 -0800 [thread overview]
Message-ID: <4730.1734122769306392060@lists.openembedded.org> (raw)
In-Reply-To: <953e09ed-9f74-a048-e8e7-c26b19be3eb2@siemens.com>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
I would like to understand why this patch series was never merged. Specifically, the patch that moves CMAKE_NO_SYSTEM_FROM_IMPORTED to toolchain.cmake seems to fix a common issue when building with OE: By default, CMake adds the SYSTEM property to all imported libraries, which lets consuming targets use stricter compiler warnings and treat warnings as errors without triggering errors from dependent targets' headers. Setting CMAKE_NO_SYSTEM_FROM_IMPORTED disables this default behaviour, oddly forcing consuming targets to fix issues that were created by the build system itself as CMAKE_NO_SYSTEM_FROM_IMPORTED applies uniformly to all imported targets the consumer links to. I've successfully built core-image-sato with CMAKE_NO_SYSTEM_FROM_IMPORTED=1 completely removed on current master. Looking at the commit history, this setting seems to have been added to address an issue that may no longer exist. Is there a rationale for keeping this setting?
[-- Attachment #2: Type: text/html, Size: 969 bytes --]
prev parent reply other threads:[~2024-12-13 20:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 10:42 [PATCH v4 0/4] cmake.bbclass improvements Pascal Bach
2018-10-17 10:42 ` [PATCH v4 1/4] cmake.bbclass: use CMAKE_SYSTEM_LIBRARY_PATH instead of CMAKE_LIBRARY_PATH Pascal Bach
2018-10-17 10:42 ` [PATCH v4 2/4] cmake.bbclass: search both sysroot-native and host for native packages Pascal Bach
2018-10-17 16:24 ` Burton, Ross
2018-10-18 15:05 ` Pascal Bach
2018-10-18 19:44 ` Burton, Ross
2018-10-17 10:42 ` [PATCH v4 3/4] cmake.bbclass: move CMAKE_NO_SYSTEM_FROM_IMPORTED to toolchain.cmake Pascal Bach
2018-10-17 10:42 ` [PATCH v4 4/4] cmake.bbclass: allow cmake to find hosttools Pascal Bach
2018-10-17 18:50 ` [PATCH v4 0/4] cmake.bbclass improvements Khem Raj
2018-10-18 14:58 ` Pascal Bach
2018-10-18 15:28 ` Khem Raj
2018-10-19 11:58 ` Pascal Bach
2024-12-13 20:46 ` Manuel Leonhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4730.1734122769306392060@lists.openembedded.org \
--to=mleonhardt@arri.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox