Re: [PATCH 1/5] archiver.bbclass: Handle gitsm URLs in the mirror archiver

Richard Purdie
2020-03-11T11:53:06Z

On Wed, 2020-03-11 at 11:50 +0000, Paul Barker wrote:
> I structured things this way after the discussions we've had previously about
> not wanting to add too many new code paths to the fetcher. I'd also like to
> keep the logic in a bbclass as much as possible so that it can be more easily
> carried as a local backport to earlier Yocto Project releases.
>
> I do see your point though, this is liable to grow warts over time as special
> cases are added for different fetchers.

I appreciate the previous discussions, but yes, this is my concern.

> The cause of the warts here is that the gitsm fetcher downloads and creates
> mirror tarballs for sources which aren't listed in SRC_URI. The archiver
> would be simpler if we could assume that all sources are included in SRC_URI.
> Perhaps the solution is not to add a "make a mirror copy" API but instead add
> an "expand SRC_URI with any dependencies" API that the archiver can call
> before it iterates over the list of sources.

Yes, that sounds like good insight into the real issue and would make
sense, I think that would improve things and alleviate my concerns.

Cheers,

Richard