From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Seebs <seebs@seebs.net>,
Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] pseudo: Add fastop reply fix
Date: Fri, 22 Sep 2017 20:12:10 +0300 [thread overview]
Message-ID: <47d049c3-4034-7224-4f81-e1aac8f8b030@linux.intel.com> (raw)
In-Reply-To: <20170922115204.37ef6f2c@seebsdell>
On 09/22/2017 07:52 PM, Seebs wrote:
>> This changes the pseudo FASTOP functionality so that a reply to the
>> operation is required. This means we then cannot lose data if a
>> connection is closed. This in turn stops corruption if we run out of
>> file handles and have to close connections.
>>
>> This tweaks the connection closure patch to update the comment there
>> which is now outdated.
>>
>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> This looks reasonable to me. I did some testing with a very similar
> patch and concluded that, while it slowed performance slightly, it
> didn't slow it nearly as much as the pre-fastop behavior did.
Also, the issue this patch is fixing is not theoretical. Setting max fd
limit to a low value (192) is causing errors on my machine:
dpkg-deb: error: maintainer script 'postinst' has bad permissions 644
(must be >=0555 and <=0775)
and with the patch they seem to go away.
Alex
next prev parent reply other threads:[~2017-09-22 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 16:41 [PATCH 1/2] staging: Reduce verbosity of log messages Richard Purdie
2017-09-22 16:41 ` [PATCH 2/2] pseudo: Add fastop reply fix Richard Purdie
2017-09-22 16:52 ` Seebs
2017-09-22 17:12 ` Alexander Kanavin [this message]
2017-09-22 19:19 ` Otavio Salvador
2017-09-22 17:00 ` ✗ patchtest: failure for "staging: Reduce verbosity of l..." and 1 more Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47d049c3-4034-7224-4f81-e1aac8f8b030@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
--cc=seebs@seebs.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox