From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: "Mittal, Anuj" <anuj.mittal@intel.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: RE: [OE-core] [PATCHv2 1/2] meson.bblcass: Remove empty egg-info directories before running meson
Date: Wed, 27 Oct 2021 15:38:24 +0000 [thread overview]
Message-ID: <47dc344778544b8e87c5afa446f6591f@axis.com> (raw)
In-Reply-To: <16B14B36E28CA53E.25242@lists.openembedded.org>
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Peter Kjellerstedt
> Sent: den 25 oktober 2021 16:07
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCHv2 1/2] meson.bblcass: Remove empty egg-info directories before running meson
>
> sstate.bbclass no longer removes empty directories to avoid a race (see
> commit 4f94d929 "sstate/staging: Handle directory creation race issue").
> Unfortunately Python apparently treats an empty egg-info directory as if
> the version it previously contained still exists and fails if a newer
> version is required, which Meson does. To avoid this, make sure there
> are no empty egg-info directories from previous versions left behind.
>
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
>
> PATCHv2: Ignore all errors from rmdir since apparently egg-info may be
> files rather than directories.
>
> meta/classes/meson.bbclass | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/meta/classes/meson.bbclass b/meta/classes/meson.bbclass
> index e124d18144..da58cb4bec 100644
> --- a/meta/classes/meson.bbclass
> +++ b/meta/classes/meson.bbclass
> @@ -103,6 +103,16 @@ meson_do_configure() {
> # https://github.com/mesonbuild/meson/commit/ef9aeb188ea2bc7353e59916c18901cde90fa2b3
> unset LD
>
> + # sstate.bbclass no longer removes empty directories to avoid a race (see
> + # commit 4f94d929 "sstate/staging: Handle directory creation race issue").
> + # Unfortunately Python apparently treats an empty egg-info directory as if
> + # the version it previously contained still exists and fails if a newer
> + # version is required, which Meson does. To avoid this, make sure there are
> + # no empty egg-info directories from previous versions left behind. Ignore
> + # all errors from rmdir since the egg-info may be a file rather than a
> + # directory.
> + rmdir ${STAGING_LIBDIR_NATIVE}/${PYTHON_DIR}/site-packages/*.egg-info 2>/dev/null || :
> +
> # Work around "Meson fails if /tmp is mounted with noexec #2972"
> mkdir -p "${B}/meson-private/tmp"
> export TMPDIR="${B}/meson-private/tmp"
Can this patch and the corresponding qemu.inc patch please be backported
to Honister now that they have been accepted for master?
//Peter
parent reply other threads:[~2021-10-27 15:38 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <16B14B36E28CA53E.25242@lists.openembedded.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47dc344778544b8e87c5afa446f6591f@axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=anuj.mittal@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox