Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: akuster <akuster808@gmail.com>, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] buildhistory.bbclass: add cloning
Date: Sun, 14 Feb 2021 17:12:59 +0000	[thread overview]
Message-ID: <497b1ddfe6674b14fd241a32c832edad62ec79be.camel@linuxfoundation.org> (raw)
In-Reply-To: <20210214155305.1797370-1-akuster808@gmail.com>

On Sun, 2021-02-14 at 15:53 +0000, akuster wrote:
> Provide a method to clone and push to a git repo
> Provide a method to pre-populate buildhistory
> Maybe remove the need for external scripts to do the same
> 
> Three new variables:
> BUILDHISTORY_CLONE - Enable the cloning function
> BUILDHISTORY_BRANCH - branch used for checkout and pushing
> BUILDHISTORY_REPO_URI - git repo uri
> 
> example:
> BUILDHISTORY_CLONE = "1"
> BUILDHISTORY_BRANCH="${DISTRO}/gatesgarth/${MACHINE}"
> BUILDHISTORY_REPO_URI = "git@gitlab.com:akuster/oe-buildhistory"
> BUILDHISTORY_PUSH_REPO = "origin ${BUILDHISTORY_BRANCH}"
> 
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta/classes/buildhistory.bbclass | 59 +++++++++++++++++++++++++++++++
>  1 file changed, 59 insertions(+)

Whether or not this is a good idea I'm not sure but I don't like the
variable names. How about configuring as:

BUILDHISTORY_CLONE = "git@gitlab.com:akuster/oe-buildhistory"
BUILDHISTORY_CLONE_BRANCH="${DISTRO}/gatesgarth/${MACHINE}"
BUILDHISTORY_PUSH_REPO = "origin ${BUILDHISTORY_BRANCH}"

?

You're unlikely to not set a repo uri if you set clone...

Cheers,

Richard




  reply	other threads:[~2021-02-14 17:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-14 15:53 [PATCH] buildhistory.bbclass: add cloning akuster
2021-02-14 17:12 ` Richard Purdie [this message]
2021-02-14 17:59   ` [OE-core] " akuster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=497b1ddfe6674b14fd241a32c832edad62ec79be.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=akuster808@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox