From: Khem Raj <raj.khem@gmail.com>
To: OE-core <openembedded-core@lists.openembedded.org>,
"Burton, Ross" <ross.burton@intel.com>
Subject: Re: [PATCH 1/1] grub-efi.bbclass: Fix path in startup.nsh for iso image.
Date: Thu, 25 Aug 2016 10:04:32 -0700 [thread overview]
Message-ID: <4A335734-632E-43D0-9D75-DADB5C5FE7F7@gmail.com> (raw)
In-Reply-To: <1471656521-52469-2-git-send-email-pranav.tipnis@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
> On Aug 19, 2016, at 6:28 PM, Pranav Tipnis <pranav.tipnis@intel.com> wrote:
>
> The path in startup.nsh for iso image is corrupted as follows:
> fs0:\EFI\BOOT^Hootx64.efi
>
> Using printf will emit correct path which is:
> fs0:\EFI\BOOT\bootx64.efi
>
> This happens because of echo command. Switching to printf
> like the one used in efi_populate() function.
This patch is ok
>
> Signed-off-by: Pranav Tipnis <pranav.tipnis@intel.com>
> ---
> meta/classes/grub-efi.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/grub-efi.bbclass b/meta/classes/grub-efi.bbclass
> index ae8ee38..178d0c8 100644
> --- a/meta/classes/grub-efi.bbclass
> +++ b/meta/classes/grub-efi.bbclass
> @@ -59,7 +59,7 @@ efi_iso_populate() {
> cp $iso_dir/${EFIDIR}/* ${EFIIMGDIR}${EFIDIR}
> cp $iso_dir/vmlinuz ${EFIIMGDIR}
> EFIPATH=$(echo "${EFIDIR}" | sed 's/\//\\/g')
> - echo "fs0:${EFIPATH}\\${GRUB_IMAGE}" > ${EFIIMGDIR}/startup.nsh
> + printf 'fs0:%s\%s\n' "$EFIPATH" "$GRUB_IMAGE" > ${EFIIMGDIR}/startup.nsh
> if [ -f "$iso_dir/initrd" ] ; then
> cp $iso_dir/initrd ${EFIIMGDIR}
> fi
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
prev parent reply other threads:[~2016-08-25 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-20 1:28 [PATCH 0/1] Fix corrupted path in startup.nsh for iso image Pranav Tipnis
2016-08-20 1:28 ` [PATCH 1/1] grub-efi.bbclass: Fix " Pranav Tipnis
2016-08-25 17:04 ` Khem Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A335734-632E-43D0-9D75-DADB5C5FE7F7@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox