Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: poky@lists.pokylinux.org, openembedded-core@lists.openembedded.org
Subject: Re: [poky] [PATCH 1/6] package.bbclass: Fix missing debug src files
Date: Wed, 16 Mar 2011 11:25:48 -0500	[thread overview]
Message-ID: <4D80E48C.4010902@windriver.com> (raw)
In-Reply-To: <1300292546.30423.1891.camel@rex>

On 3/16/11 11:22 AM, Richard Purdie wrote:
> On Wed, 2011-03-16 at 11:15 -0500, Mark Hatle wrote:
>> The previous change used egrep instead of fgrep.  We need to use fgrep because
>> there are expression like syntaxes in some file names, we need exact matches.
>>
>> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
>> ---
>>  meta/classes/package.bbclass |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
>> index a7a5894..ac30cbe 100644
>> --- a/meta/classes/package.bbclass
>> +++ b/meta/classes/package.bbclass
>> @@ -233,9 +233,10 @@ def splitfile2(debugsrcdir, d):
>>         processdebugsrc =  "LC_ALL=C ; sort -z -u '%s' | egrep -v -z '(<internal>|<built-in>)$' | "
>>         # We need to ignore files that are not actually ours
>>         # we do this by only paying attention to items from this package
>> -       processdebugsrc += "egrep -z '%s' | "
>> +       processdebugsrc += "fgrep -z '%s' | "
>>         processdebugsrc += "(cd '%s' ; cpio -pd0mL '%s%s' 2>/dev/null)"
>>  
>> +       bb.note(processdebugsrc % (sourcefile, workbasedir, workparentdir, dvar, debugsrcdir))
>>         os.system(processdebugsrc % (sourcefile, workbasedir, workparentdir, dvar, debugsrcdir))
>>  
>>         # The copy by cpio may have resulted in some empty directories!  Remove these
> 
> Did you mean to leave the bb.note() in?

No, that was supposed to be removed.  Should I yank it and re-push the commit?

--Mark

> Cheers,
> 
> Richard
> 




  reply	other threads:[~2011-03-16 16:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16 16:15 [PATCH 0/6] Fix a number of rpm/zypper issues and related Mark Hatle
2011-03-16 16:15 ` [PATCH 1/6] package.bbclass: Fix missing debug src files Mark Hatle
2011-03-16 16:22   ` [poky] " Richard Purdie
2011-03-16 16:25     ` Mark Hatle [this message]
2011-03-16 16:47       ` Richard Purdie
2011-03-16 16:15 ` [PATCH 2/6] rootfs_rpm.bbclass: Add additional system configuration to RPM space Mark Hatle
2011-03-16 16:15 ` [PATCH 3/6] libzypp: Fix release query Mark Hatle
2011-03-16 16:15 ` [PATCH 4/6] sat-solver: uprev to the latest version Mark Hatle
2011-03-16 16:15 ` [PATCH 5/6] sat-solver: Add workaround for RPM 5 db construction Mark Hatle
2011-03-16 16:15 ` [PATCH 6/6] rpm: Disable repackage on upgrade/erasure by default Mark Hatle
2011-03-16 16:47 ` [poky] [PATCH 0/6] Fix a number of rpm/zypper issues and related Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D80E48C.4010902@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=poky@lists.pokylinux.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox