Re: [PATCH 47/58] setuptools: Make options for setup.py more flexible

From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>,
	 Gary Thomas <gary@mlbassoc.com>
Cc: Scott Rifenbark <scott.m.rifenbark@intel.com>,
	Xiaofeng Yan <xiaofeng.yan@windriver.com>,
	Paul Eggleton <paul.eggleton@linux.intel.com>,
	Koen Kooi <koen@dominion.thruhere.net>,
	Jingdong Lu <jingdong.lu@windriver.com>,
	Kang Kai <kai.kang@windriver.com>
Subject: Re: [PATCH 47/58] setuptools: Make options for setup.py more flexible
Date: Sat, 16 Apr 2011 14:43:58 -0700	[thread overview]
Message-ID: <4DAA0D9E.80901@linux.intel.com> (raw)
In-Reply-To: <A377F56D-F244-4BBE-8004-37CCCB477F26@dominion.thruhere.net>

On 04/16/2011 12:46 PM, Koen Kooi wrote:
> furthermore both distutils and setuptools use the classes in sysroot, so the 'some versions' part of the argument is bogus.
>
Koen,

Thanks, I guess missed your comments on this issue, thanks for pointing 
them out.

Richard: Please disregard this patch.

Sau!

> Op 16 apr. 2011 om 14:11 heeft Koen Kooi<koen@dominion.thruhere.net>  het volgende geschreven:
>
>> As I said in my other mail, the reasoning behind this patch is wrong and will lead to broken output. The '--single-version-externally-managed' is needed to stop the python egg code from doing the wrong thing. People running into problems with this need to do 'inherit distutils' instead of 'inherit setuptools'.
>>
>> Besides all that, 'DISTUTILS_INSTALL_EXTRA_ARGS' would be the correct name for such a thing.
>>
>> Op 16 apr 2011, om 08:55 heeft Saul Wold het volgende geschreven:
>>
>>> From: Gary Thomas<gary@mlbassoc.com>
>>>
>>> The setuptools class uses hard-wired options for 'setup.py' during
>>> the install step.  In particular, not all versions of setup.py
>>> support the "--single-version-externally-managed" option.  This
>>> patch allows for a recipe to easily override these options, while
>>> leaving the majority (important) setup options intact.
>>>
>>> --
>>> ------------------------------------------------------------
>>> Gary Thomas                 |  Consulting for the
>>> MLB Associates              |    Embedded world
>>> ------------------------------------------------------------
>>>
>>>>  From 0afbe6b9477c207e37009c8ef5aa47b3438640a9 Mon Sep 17 00:00:00 2001
>>> From: Gary Thomas<gary@mlbassoc.com>
>>> Date: Wed, 13 Apr 2011 15:12:57 -0600
>>> Subject: [PATCH] setuptools: Make options for setup.py more flexible
>>>
>>> Signed-off-by: Gary Thomas<gary@mlbassoc.com>
>>> Signed-off-by: Saul Wold<sgw@linux.intel.com>
>>> ---
>>> meta/classes/setuptools.bbclass |    3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/meta/classes/setuptools.bbclass b/meta/classes/setuptools.bbclass
>>> index ced9509..cf1c224 100644
>>> --- a/meta/classes/setuptools.bbclass
>>> +++ b/meta/classes/setuptools.bbclass
>>> @@ -2,7 +2,8 @@ inherit distutils
>>>
>>> DEPENDS += "python-setuptools-native"
>>>
>>> +DISTUTILS_INSTALL_OPTS ?= "--single-version-externally-managed "
>>> DISTUTILS_INSTALL_ARGS = "--root=${D} \
>>> -    --single-version-externally-managed \
>>> +    ${DISTUTILS_INSTALL_OPTS} \
>>>     --prefix=${prefix} \
>>>     --install-data=${datadir}"
>>> --
>>> 1.7.1.1
>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core