From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com ([134.134.136.20]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1QFfSB-0006br-RC for openembedded-core@lists.openembedded.org; Fri, 29 Apr 2011 06:37:20 +0200 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 28 Apr 2011 21:34:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.64,284,1301900400"; d="scan'208";a="635673632" Received: from unknown (HELO [10.255.13.18]) ([10.255.13.18]) by orsmga002.jf.intel.com with ESMTP; 28 Apr 2011 21:34:45 -0700 Message-ID: <4DBA3FE4.8040501@linux.intel.com> Date: Thu, 28 Apr 2011 21:34:44 -0700 From: Saul Wold User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5 MIME-Version: 1.0 To: Patches and discussions about the oe-core layer References: <1303981552.21461.43.camel@rex> <4DBA3EE3.6020006@linux.intel.com> In-Reply-To: <4DBA3EE3.6020006@linux.intel.com> Cc: Darren Hart , Antonio Ospite , Chris Larson Subject: Re: [PATCH 34/52] logging: add bb* logging mechanisms for bash recipe functions X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2011 04:37:20 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 04/28/2011 09:30 PM, Darren Hart wrote: > > > On 04/28/2011 02:05 AM, Richard Purdie wrote: >> Hi Darren, >> >> On Wed, 2011-04-27 at 00:29 -0700, Saul Wold wrote: >>> The following logging mechanisms are to be used in bash functions of recipes. >>> They are intended to map one to one in intention and output format with the >>> python recipe logging functions of a similar naming convention: bb.plain(), >>> bb.note(), etc. >>> >>> For the time being, all of these print only to the task logs. Future >>> enhancements may integrate these calls with the bitbake logging infrastructure, >>> allowing for printing to the console as appropriate. The interface and intention >>> statements reflect that future goal. Once it is in place, no changes will be >>> necessary to recipes using these logging mechanisms. >> >> This looks good but could you do a search and replace of any existing >> users of the oe* functions and then remove them from base.bbclass >> please? At the very least they should be calling the bb* equivalents. >> I'd like to clean up this kind of thing as we go. > > Sure thing. Is a follow-up patch acceptable or do you want me to > resubmit these in one series? > Since we have pulled this set, a follow-up patch would be most excellent! Thanks Sau! > -- > Darren > >> >> Cheers, >> >> Richard >> >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >