Re: [PATCH 0/1] poky-default-revisions: move SRCREV to every recipe

[Yu Ke <ke.yu@intel.com>]

on 2011-5-4 22:24, Frans Meulenbroeks wrote:
> 2011/5/4 Richard Purdie<richard.purdie@linuxfoundation.org>
>
>> On Wed, 2011-05-04 at 22:05 +0800, Yu Ke wrote:
>>> From: Yu Ke<ke.yu@intel.com>
>>>
>>> move the SRCREV from poky-default-revisions.inc to its corresponding
>> recipe,
>>> in this case, those non poky distro can also use its SRCREV.
>>>
>>> Pull URL: git://git.pokylinux.org/poky-contrib.git
>>>    Branch: kyu3/srcrev-recipe
>>>    Browse:
>> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kyu3/srcrev-recipe
>>>
>>> Thanks,
>>>      Yu Ke<ke.yu@intel.com>
>>> ---
>>>
>>>
>>> Yu Ke (1):
>>>    poky-default-revisions: move the SRCREV to recipe file
>>
>> Merged to master, thanks for resolving this issue! :)
>>
>> Cheers,
>>
>> Richard
>>
>> I would have preferred a more standardised placement of SRCREV.
> Most of the time the SRCREV is before the PV, but not always (and sometimes
> separated with an empty line and sometimes not).
>
> Also there is at least one error introduced:
>
> diff --git a/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bbb/meta/recipes-devtools/yaffs2/
> yaffs2-utils_cvs.bb
> index 6171fe5..c729c7c 100644
> --- a/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb<http://git.pokylinux.org/cgit.cgi/poky-contrib/tree/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb?h=kyu3/srcrev-recipe&id=d2e078aa046ae6c4f169695f546cf229db5be1f7>
> +++ b/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb<http://git.pokylinux.org/cgit.cgi/poky-contrib/tree/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb?h=kyu3/srcrev-recipe&id=c75b49ff5cfd10f5187af2b66a0a8d5513460374>
> @@ -1,3 +1,4 @@
> require yaffs2-utils.inc
> PR = "r1"
> +SRCDAT = "20071107"
>
> That should be SRCDATE. There might be more of these, my eye just fell on
> this one.

Thanks for pointing it out. For unknown reason, my proxy does not work 
in cvs fetcher , so this recipe is untested. I should take more care on 
this. A patch is just sent out to fix it.

Regards
Ke

>
> Frans
>
> PS: speaking of yaffs2 utils: it could be considered to move to a somewhat
> newer version (not that I care as I do not use yaffs2)
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>