Re: [PATCH] create-pull-request: Add -l location switch

[Darren Hart <dvhart@linux.intel.com>]

On 05/11/2011 10:03 AM, Richard Purdie wrote:
> On Tue, 2011-05-10 at 16:01 -0700, Tom Rini wrote:
>> On 05/10/2011 12:18 PM, Otavio Salvador wrote:
>>> On Tue, May 10, 2011 at 15:55, Tom Rini <tom_rini@mentor.com> wrote:
>>>> Add a -l switch that takes an argument of either github or gitorious
>>>> and will make the cover letter have a fill-in-the-blank of where the
>>>> changes are on either github or gitorious.
>>>
>>> Another possibility would be to use git config interface to store
>>> those. You might have something like:
>>>
>>> [oe-core-pull-request]
>>> mode = github
>>> user = foo
>>>
>>> or
>>>
>>> [oe-core-pull-request]
>>> mode = gitorious
>>> user = bar
>>>
>>> This could be used to fill the fields in a proper way since those are
>>> predictable.
>>
>> If I had a good bit more time, I might re-write the script in python and
>> parse .ini files (same syntax as gitconfig) so that lots of useful
>> defaults could be saved.  But here's the real test, given that you're an
>> intended user, would you use the -l switch or just make a local change
>> to the script like Martin showed?
> 
> FWIW, we could at least extract a url from the .config of the git
> repository with a command like "git remote -v show oe-core-pull-request"

It just depends on specific naming... hrm... or we could specify the
remote on the command line instead of the full URL. That would make the
specification each time much less onerous.

We would have to rewrite 'ssh://git@' to 'git://' for some URLs as I
suspect most users don't have different push/fetch URLs (I don't).

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel