Re: [RFC PATCH 10/10] send-pull-request: verify git sendemail config

[Darren Hart <dvhart@linux.intel.com>]

On 05/13/2011 10:43 PM, Bruce Ashfield wrote:
> On Fri, May 13, 2011 at 7:38 PM, Darren Hart <dvhart@linux.intel.com> wrote:
>> Perform a quick sanity check to be able to direct users to configure
>> git.sendemail if they haven't yet.
>>
>> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
>> ---
>>  scripts/send-pull-request |   15 +++++++++++++++
>>  1 files changed, 15 insertions(+), 0 deletions(-)
>>
>> diff --git a/scripts/send-pull-request b/scripts/send-pull-request
>> index f94596f..2ccb8e8 100755
>> --- a/scripts/send-pull-request
>> +++ b/scripts/send-pull-request
>> @@ -38,6 +38,18 @@ harvest_recipients()
>>        unset IFS
>>  }
>>
>> +check_git_sendemail_config()
>> +{
>> +       GIT_SMTP=$(git config sendemail.smtpserver)
>> +       GIT_FROM=$(git config sendemail.from)
>> +       if [ -z "$GIT_SMTP" ] || [ -z "$GIT_FROM" ]; then
>> +               echo "ERROR: git sendemail is not configured."
>> +               echo "Please read GIT-SEND-EMAIL(1) and configure:"
>> +               echo "  sendemail.smtpserver"
>> +               echo "  sendemail.from"
> 
> I was going to ask for this to be optional, since I always pass the smtp
> settings on the command line .. but then I realized that I invoke git send-email
> directly anyway, so I don't need it to be optional. :)
> 
> Regardless, reading this from git config is good idea, so the above is
> only a comment.

This only impacts the send-pull-request script which requires
git-send-email to be configured in order to work, so it really can't be
an optional thing.

--
Darren

> 
> Bruce
> 
>> +               exit 1
>> +       fi
>> +}
>>
>>  # Parse and verify arguments
>>  while getopts "ahp:t:" OPT; do
>> @@ -67,6 +79,9 @@ while getopts "ahp:t:" OPT; do
>>        esac
>>  done
>>
>> +# Abort early if git-send-email is not properly configured
>> +check_git_sendemail_config
>> +
>>  if [ -z "$PDIR" ]; then
>>        echo "ERROR: you must specify a pull-dir."
>>        usage
>> --
>> 1.7.1
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
> 
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel