From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga03.intel.com ([143.182.124.21])
	by linuxtogo.org with esmtp (Exim 4.72)
	(envelope-from <sgw@linux.intel.com>) id 1QPHmy-000857-UE
	for openembedded-core@lists.openembedded.org;
	Wed, 25 May 2011 19:22:33 +0200
Received: from azsmga001.ch.intel.com ([10.2.17.19])
	by azsmga101.ch.intel.com with ESMTP; 25 May 2011 10:19:29 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.65,268,1304319600"; 
   d="scan'208";a="1564888"
Received: from unknown (HELO [10.255.12.133]) ([10.255.12.133])
	by azsmga001.ch.intel.com with ESMTP; 25 May 2011 10:19:28 -0700
Message-ID: <4DDD3A20.5080801@linux.intel.com>
Date: Wed, 25 May 2011 10:19:28 -0700
From: Saul Wold <sgw@linux.intel.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc13 Thunderbird/3.1.10
MIME-Version: 1.0
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
References: <1306248550.2525.196.camel@phil-desktop>
In-Reply-To: <1306248550.2525.196.camel@phil-desktop>
Subject: Re: [PATCH] rootfs_ipk: issue a diagnostic if rootfs is declared read-only and not all maintainer scripts could be applied offline
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.11
Precedence: list
Reply-To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.linuxtogo.org/pipermail/openembedded-core>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Wed, 25 May 2011 17:22:33 -0000
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 05/24/2011 07:49 AM, Phil Blundell wrote:
>
> Signed-off-by: Phil Blundell<philb@gnu.org>
> ---
>   meta/classes/rootfs_ipk.bbclass |   10 ++++++++++
>   1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/meta/classes/rootfs_ipk.bbclass b/meta/classes/rootfs_ipk.bbclass
> index 4c8088b..99584eb 100644
> --- a/meta/classes/rootfs_ipk.bbclass
> +++ b/meta/classes/rootfs_ipk.bbclass
> @@ -54,17 +54,27 @@ fakeroot rootfs_ipk_do_rootfs () {
>   	${OPKG_POSTPROCESS_COMMANDS}
>   	${ROOTFS_POSTINSTALL_COMMAND}
>   	
> +	runtime_script_required=0
>   	for i in ${IMAGE_ROOTFS}${opkglibdir}/info/*.preinst; do
>   		if [ -f $i ]&&  ! sh $i; then
> +		     	runtime_script_required=1
>   			opkg-cl ${IPKG_ARGS} flag unpacked `basename $i .preinst`
>   		fi
>   	done
>   	for i in ${IMAGE_ROOTFS}${opkglibdir}/info/*.postinst; do
>   		if [ -f $i ]&&  ! sh $i configure; then
> +		     	runtime_script_required=1
>   			opkg-cl ${IPKG_ARGS} flag unpacked `basename $i .postinst`
>   		fi
>   	done
>
> +	if ${@base_contains("IMAGE_FEATURES", "read-only-rootfs", "true", "false" ,d)}; then
> +		if [ $runtime_script_required -eq 1 ]; then
> +			echo "Some packages could not be configured offline and rootfs is read-only."
> +			exit 1
> +		fi
> +	fi
> +
>   	install -d ${IMAGE_ROOTFS}/${sysconfdir}
>   	echo ${BUILDNAME}>  ${IMAGE_ROOTFS}/${sysconfdir}/version
>
Merged into OE-Core

Thanks
	Sau!