Re: [PATCH 0/1] oe-setup-builddir: remove unreachable code, update comments

[Darren Hart <dvhart@linux.intel.com>]

On 05/24/2011 11:32 PM, Saul Wold wrote:
> On 05/24/2011 03:31 PM, Darren Hart wrote:
>> From: Darren Hart<dvhart@linux.intel.com>
>>
>> The following changes since commit 32a4e746273c3c7d3dd0f13b745bc0679cadaa44:
>>
>>    codeparser.py: fix syntax error in exception handling (2011-05-24 17:16:47 +0100)
>>
>> are available in the git repository at:
>>    git://git.pokylinux.org/poky-contrib.git dvhart/build
>>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dvhart/build
>>
>> Darren Hart (1):
>>    oe-setup-builddir: remove unreachable code, update comments
>>
>>   scripts/create-pull-request |    2 +-
>>   scripts/oe-setup-builddir   |   32 +++++++++++++-------------------
>>   2 files changed, 14 insertions(+), 20 deletions(-)
>>
>>
> If this is intended for oe-core, please rebase to oe-core and resend, I 
> had a merge issue and want to make sure I am getting the right code 
> committed.


Gah, right. I saw the oe- in the script name and just had oe-core in my
head. Apologies. The two scripts are slightly different in the two
repositories, but both suffer from the same unreachable code problem.

Would you prefer I send two patches, one for each repository, or that I
push to one or the other and let you handle the merge process as part of
the regular sync up process (whatever that is).

Before I do that - are people in agreement with the approach? ie Should
I be removing the unreachable code or should I instead making it usable
again, reestablishing the functionality of OELOCALCONF and OELAYERSCONF?

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel