Re: [bugfix 1/1] mesa-xlib: workaround gcc 4.6.0 ICE

[Darren Hart <darren.hart@intel.com>]

On 05/26/2011 01:41 PM, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> Fixes this bug [YOCTO #1105]
> 
> Working around this issue withg gcc 4.6.0 for beagleboard machine (armv7)
> 
> ccache arm-poky-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon
> -mfloat-abi=softfp -fno-tree-vectorize
> --sysroot=/build_disk/poky_build/build0/tmp/sysroots/beagleboard -c -I.
> -I../../../../src/gallium/include -I../../../../src/gallium/auxiliary
> -I../../../../src/gallium/drivers
> -I../../../../src/gallium/drivers/svga/include -O2 -pipe -g
> -feliminate-unused-debug-types -Wall -Wmissing-prototypes -std=c99 -ffast-math
> -fvisibility=hidden -fno-strict-aliasing -fPIC -D_GNU_SOURCE -DPTHREADS
> -DHAVE_POSIX_MEMALIGN -DUSE_XSHM -std=gnu99 -fvisibility=hidden -DHAVE_STDINT_H
> -DHAVE_SYS_TYPES_H svga_tgsi_insn.c -o svga_tgsi_insn.o
> svga_tgsi_insn.c: In function 'svga_shader_emit_instructions':
> svga_tgsi_insn.c:2969:1: internal compiler error: in push_minipool_fix, at
> config/arm/arm.c:12084
> Please submit a full bug report,
> with preprocessed source if appropriate.
> See <http://gcc.gnu.org/bugs.html> for instructions.
> make[4]: *** [svga_tgsi_insn.o] Error 1
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/recipes-graphics/mesa/mesa-xlib_7.10.2.bb |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-graphics/mesa/mesa-xlib_7.10.2.bb b/meta/recipes-graphics/mesa/mesa-xlib_7.10.2.bb
> index b77df2c..051bd72 100644
> --- a/meta/recipes-graphics/mesa/mesa-xlib_7.10.2.bb
> +++ b/meta/recipes-graphics/mesa/mesa-xlib_7.10.2.bb
> @@ -17,3 +17,6 @@ PE = "1"
>  PR = "r0"
>  
>  EXTRA_OECONF += "--with-driver=xlib"
> +
> +# nullify -O2

Can we specify why this is being done here in the recipe? We do this in
other areas, something like:

# GCC 4.6.0 hits an internal compiler error using -O2
# use -O to workaround.

This make it obvious when looking just at the source why this is an
issue, and will trigger a retest and removal when we move past 4.6.0.
Also, if there is a bug number, linking that here would make it easy to
determine if a fix is ready.

> +CFLAGS_append += " -O"

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel