Re: [PATCH 1/2] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES

[Darren Hart <dvhart@linux.intel.com>]

On 05/27/2011 07:48 AM, Richard Purdie wrote:
> On Fri, 2011-05-27 at 15:46 +0100, Richard Purdie wrote:
>> On Fri, 2011-05-27 at 06:56 -0700, Darren Hart wrote:
>>>
>>> On 05/27/2011 01:40 AM, Richard Purdie wrote:
>>>> On Thu, 2011-05-26 at 20:43 -0700, Darren Hart wrote:
>>>>> On 05/26/2011 04:24 PM, Richard Purdie wrote:
>>>>>> On Thu, 2011-05-26 at 14:12 -0700, Darren Hart wrote:
>>>>>>> Note: I used bb.note() instead of bb.debug() to ensure the message at least
>>>>>>>       makes it to the console. From what I could gather, bb.debug() doesn't
>>>>>>>       go anywhere during recipe parsing.
>>>>>>
>>>>>> Why?
>>>>>>
>>>>>
>>>>> My thinking was that the only time you would legitimately try and build
>>>>> this package when you can't is during a "world" build, which is likely
>>>>> an unattended sort of build anyway. The rest of the time you might hit
>>>>> this error would be when you intended to build u-boot but are missing
>>>>> the requisite configuration bits in your machine config.
>>>>
>>>> You've inserted the note at parsing time though so every time anyone
>>>> builds anything this will show up.
>>>
>>> Aha! Got it. I changed it and ran a test:
>>>
>>> bb.note("DEBUG TO FOLLOW")
>>> bb.debug(1, "To build %s, see %s for instructions on setting \
>>> 	     up your machine config" % (PN, FILE))
>>>
>>>
>>> $ rm -rf tmp/cache; bitbake -DDDD u-boot | tee log
>>> Pseudo is not present but is required, building this first before the
>>> main build
>>> Loading cache...done.
>>> Loaded 998 entries from dependency cache.
>>> Parsing recipes...NOTE: DEBUG TO FOLLOW
>>> done.
>>> Parsing of 783 .bb files complete (780 cached, 3 parsed). 1000 targets,
>>> 11 skipped, 0 masked, 0 errors.
>>>
>>> As you can see, even with -DDDD, the message never makes it to the
>>> console. So I agree that bb.note() is inappropriate, unfortunately,
>>> bb.debug doesn't appear to be working. I believe it was yesterday...
>>
>> The result was cached (780 cached). Try that command after "touch
>> conf/local.conf" and it will be in there.
> 
> Sorry, the note did appear though.
> 
> That needs looking into and is possibly a logging problem. Needs fixing
> as a separate issue though and use of bb.note there isn't the right
> approach.


OK, I haven't completely lost it then :-) In that case, are you looking
for any additional changes/dialog/acks here? If not, the version with
bb.debug() is now in the contrib branch:

  git://git.pokylinux.org/poky-contrib dvhart/oe/u-boot
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dvhart/oe/u-boot

I can resend as V3 if more discussion is desirable.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel