From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com ([134.134.136.24]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1QQNm2-0004Hs-9u for openembedded-core@lists.openembedded.org; Sat, 28 May 2011 19:58:06 +0200 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 28 May 2011 10:54:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,286,1304319600"; d="scan'208";a="6247396" Received: from unknown (HELO [10.255.13.47]) ([10.255.13.47]) by orsmga001.jf.intel.com with ESMTP; 28 May 2011 10:54:58 -0700 Message-ID: <4DE136F2.8030407@intel.com> Date: Sat, 28 May 2011 10:54:58 -0700 From: Elizabeth Flanagan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 MIME-Version: 1.0 To: openembedded-core@lists.openembedded.org References: <4DE02216.1010003@intel.com> <4DE128F5.1070603@gmail.com> In-Reply-To: <4DE128F5.1070603@gmail.com> Subject: Re: [PATCH 0/1][v3] license.bbclass parsing changes rebased sans debug X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 May 2011 17:58:06 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit In this case, elfutils should probably be changes as well as license.bbclass. As do_populate_lic is looking for valid python to make a syntax tree from, this will fail. Solution: 1. Fix license.bbclass to check LICENSE and massage it a bit more. 2. Fix elfutils to be GPLv2* (unless it's the GCC exception. I haven't read the license yet). I'll poke around this today. -b On 05/28/2011 09:55 AM, Khem Raj wrote: > On 5/28/2011 2:16 AM, Koen Kooi wrote: >> >> Op 28 mei 2011, om 00:13 heeft Elizabeth Flanagan het volgende geschreven: >> >>> >>> Using python abstract syntax trees as a parser and an ast visitor class, I've >>> begun the first steps to being able to put some sanity to license selection. >>> >>> One note. License modifiers have traditionally been limited to the "or greater" >>> modifier "+". I've added another modifier "with exceptions" for licenses that >>> have no generic ie common-licenses/GPL-2,0-with-GCC-exception >> >> When building shadow I get: > > > and when building elfutils I get > > ERROR: (file: 'do_populate_lic', lineno: 116, function: do_populate_lic) > ERROR: Function 'do_populate_lic' failed > ERROR: Logfile of failure stored in: > /home/kraj/work/slugos/build/tmp-slugos-eglibc/work/armv5te-oe-linux-gnueabi/elfutils-0.148-r2/temp/log.do_populate_lic.31784 > Log data follows: > | WARNING: > /home/kraj/work/slugos/openembedded-core/meta/files/common-licenses > | ERROR: Error executing a python function in > /home/kraj/work/slugos/openembedded-core/meta/recipes-devtools/elfutils/elfutils_0.148.bb: > | File "", line 1 > | ( 'GPLv2'& 'Exception' ) > | ^ > | IndentationError: unexpected indent > | > | ERROR: The stack trace of python calls that resulted in this > exception/failure was: > | ERROR: File "do_populate_lic", line 121, in > | ERROR: > | ERROR: File "do_populate_lic", line 116, in do_populate_lic > | ERROR: > | ERROR: File "/usr/lib/python2.7/ast.py", line 37, in parse > | ERROR: return compile(source, filename, mode, PyCF_ONLY_AST) > | ERROR: > | ERROR: The code that was being executed was: > | ERROR: 0117: v = LicenseVisitor() > | ERROR: 0118: v.visit(node) > | ERROR: 0119: > | ERROR: 0120: > | ERROR: *** 0121:do_populate_lic(d) > | ERROR: 0122: > | ERROR: (file: 'do_populate_lic', lineno: 121, function:) > | ERROR: 0112: clean_licenses += "'" + x + "'" > | ERROR: 0113: else: > | ERROR: 0114: clean_licenses += " " + x + " " > | ERROR: 0115: > | ERROR: *** 0116: node = ast.parse(clean_licenses) > | ERROR: 0117: v = LicenseVisitor() > | ERROR: 0118: v.visit(node) > | ERROR: 0119: > | ERROR: 0120: > | ERROR: (file: 'do_populate_lic', lineno: 116, function: do_populate_lic) > | ERROR: Function 'do_populate_lic' failed > NOTE: package elfutils-0.148-r2: task do_populate_lic: Failed > > >> >> | WARNING: /home/koen/angstrom-core/sources/openembedded-core/meta/files/common-licenses >> | ERROR: Error executing a python function in /home/koen/angstrom-core/sources/openembedded-core/meta/recipes-extended/shadow/shadow_4.1.4.3.bb: >> | RuntimeError: maximum recursion depth exceeded while calling a Python object >> | >> | ERROR: The stack trace of python calls that resulted in this exception/failure was: >> | ERROR: File "do_populate_lic", line 121, in >> | ERROR: >> | ERROR: File "do_populate_lic", line 118, in do_populate_lic >> | ERROR: >> | ERROR: File "/usr/lib64/python2.7/ast.py", line 243, in visit >> | ERROR: return visitor(node) >> | ERROR: >> | ERROR: File "do_populate_lic", line 13, in generic_visit >> >> and a few hundred more lines, I had to change the scrollback buffer from 512 lines to unlimited to catch this :) I can send the full log on request. >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > -- --------------- Elizabeth Flanagan Yocto Project Release Engineer